Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.62k stars 5.04k forks source link

`Microsoft.Web/connections` missing `parameterValueType` #20851

Open Dyhr opened 2 years ago

Dyhr commented 2 years ago

According to these docs on Managed Identity and API Connections (https://learn.microsoft.com/en-us/azure/logic-apps/create-managed-service-identity?tabs=consumption#single-authentication) there should be a property parameterValueType on Microsoft.Web/connections, but it appears to be missing from this spec https://github.com/Azure/azure-rest-api-specs/blob/1d9c9c68844d2b5883621069d5bf0c958841782f/specification/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json#L1859-L1920

I need this downstream to eventually be available in the Hashicorp's Terraform provider.

navba-MSFT commented 1 year ago

@Dyhr Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

navba-MSFT commented 1 year ago

@Dyhr Could you please refer this article ? and see the output response they have got.

image

Is it the parameterValueSet you are referring to ?

This is the REST API they have invoked:

https://management.azure.com/subscriptions/< Your subscription id >/resourceGroups/< Your Resource Group Name >/providers/Microsoft.Web/connections/< API connection name >?api-version=2018-07-01-preview

Could you please try the and check if that helps ? Awaiting your reply.

navba-MSFT commented 1 year ago

@Dyhr I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you had any updates on this. Awaiting your reply.

Dyhr commented 1 year ago

@navba-MSFT Thank you for your response. Unfortunately my issue is not that the API isn't working, but the discrepancy between the spec and the API, according to the documentation I linked.

The documentation refers to parameterValueType for Single-authentication and parameterValueSet for Multi-authentication. While I only need the former, neither seems to be in the spec that I linked for API version 2016-06-01 specifically. Please correct me if I'm incorrect and just not seeing it.

I need it to be in the spec, because downstream, code is generated based on the spec. Running someone else's example does not help me.

navba-MSFT commented 1 year ago

@Dyhr Thanks for getting back and clarifying the ask. I am adding the Service team to look into this.

ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-logicapps-team.

Issue Details
According to these docs on Managed Identity and API Connections (https://learn.microsoft.com/en-us/azure/logic-apps/create-managed-service-identity?tabs=consumption#single-authentication) there should be a property `parameterValueType` on `Microsoft.Web/connections`, but it appears to be missing from this spec https://github.com/Azure/azure-rest-api-specs/blob/1d9c9c68844d2b5883621069d5bf0c958841782f/specification/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json#L1859-L1920 I need this downstream to eventually be available in the Hashicorp's Terraform provider.
Author: Dyhr
Assignees: navba-MSFT
Labels: `question`, `Logic App`, `Service Attention`, `customer-reported`, `needs-team-attention`
Milestone: -
navba-MSFT commented 1 year ago

@Azure/azure-logicapps-team Could you please look into this and provide an update ?

Megasware128 commented 1 year ago

Bicep is also hit by this issue: https://github.com/Azure/bicep-types-az/issues/1990. Same for Pulumi

Dyhr commented 1 year ago

@navba-MSFT , if the Logic Apps team doesn't respond soon, is it possible for us to contribute the change ourselves?

navba-MSFT commented 1 year ago

@Dyhr Feel free to create a Pull Request to perform the necessary changes and that PR will be reviewed by the Logic App Service team before they approve those changes.