Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.69k stars 5.11k forks source link

network/SubResource added with and without required `id` #21431

Open thomas11 opened 2 years ago

thomas11 commented 2 years ago

In the latest Networking 2022-07-01 release (0c90b40551), dnsresolver/resource-manager/Microsoft.Network/stable/2022-07-01/dnsresolver.json adds SubResource with an id property that's required.

However, SubResource already exists in Network, defined in various API versions of network, e.g., network/resource-manager/Microsoft.Network/preview/2022-04-01-preview/network.json. This SubResource also has the id property, but not required. This causes a conflict between two different resource definitions in the same namespace.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dnssuppgithub.

Issue Details
In the latest Networking 2022-07-01 release (0c90b40551), [`dnsresolver/resource-manager/Microsoft.Network/stable/2022-07-01/dnsresolver.json` adds `SubResource`](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dnsresolver/resource-manager/Microsoft.Network/stable/2022-07-01/dnsresolver.json#L2497) with an `id` property that's required. However, `SubResource` already exists in Network, defined in various API versions of `network`, e.g., `network/resource-manager/Microsoft.Network/preview/2022-04-01-preview/network.json`. This SubResource also has the `id` property, but not required. This causes a conflict between two different resource definitions in the same namespace.
Author: thomas11
Assignees: -
Labels: `question`, `Network - DNS`, `Service Attention`, `customer-reported`, `needs-triage`
Milestone: -
navba-MSFT commented 2 years ago

@dnssuppgithub COuld you please look into this and provide an update ?

thomas11 commented 1 month ago

You've added another instance of this now with SubResource and NspAssociation, in 5c26c3b83ddc9b459d6eece1b3495d2a56bffa5a.