Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.67k stars 5.09k forks source link

[FEATURE] Support HubVirtualNetworkConnectionProperties ConnectivityStatus #21505

Open kuwas opened 1 year ago

kuwas commented 1 year ago

Feature Request

Support HubVirtualNetworkConnectionProperties struct ConnectivityStatus field.

type HubVirtualNetworkConnectionProperties struct {
  ConnectivityStatus *ConnectivityStatus `json:"connectivityStatus,omitempty" azure:"ro"`
}

This field appears to be undocumented in the Azure REST API and even the Azure .NET SDK docs. However, it's in the live response and portal.azure.com UI. I've tested 2 versions so far, and it's present in both:

{
  "name": "<redacted>",
  "id": "<redacted>",
  "etag": "<redacted>",
  "type": "Microsoft.Network/virtualHubs/hubVirtualNetworkConnections",
  "properties": {
    "provisioningState": "Succeeded",
    "resourceGuid": "<redacted>",
    "routingConfiguration": {
      "associatedRouteTable": {
        "id": "<redacted>"
      },
      "propagatedRouteTables": {
        "labels": [
          "none"
        ],
        "ids": [
          {
            "id": "<redacted>"
          }
        ]
      },
      "vnetRoutes": {
        "staticRoutes": [],
        "staticRoutesConfig": {
          "propagateStaticRoutes": false,
          "vnetLocalRouteOverrideCriteria": "Contains"
        }
      }
    },
    "remoteVirtualNetwork": {
      "id": "<redacted>"
    },
    "allowHubToRemoteVnetTransit": true,
    "allowRemoteVnetToUseHubVnetGateways": true,
    "enableInternetSecurity": true,
    "connectivityStatus": "Connected"
  }
}

cc: @juicybaba

ghost commented 1 year ago

Hi @kuwas. Thank you for your feedback and we will look into it soon. Meanwhile, feel free to share your experience using the Azure SDK in this survey.

lirenhe commented 1 year ago

This seems to be a Swagger correctness issue. @tadelesh, could you help to double check?

tadelesh commented 1 year ago

Yes. It is a swagger correctness issue. @kuwas I'll migrate this issue to the swagger repo and involve service team then.

navba-MSFT commented 1 year ago

Adding Service team to look into this.

ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

Issue Details
### Feature Request Support `HubVirtualNetworkConnectionProperties` struct `ConnectivityStatus` field. ``` type HubVirtualNetworkConnectionProperties struct { ConnectivityStatus *ConnectivityStatus `json:"connectivityStatus,omitempty" azure:"ro"` } ``` This field appears to be **undocumented** in the Azure REST API and even the Azure .NET SDK docs. However, it's in the live response and portal.azure.com UI. I've tested 2 versions so far, and it's present in both: * `2022-01-01` * `2022-05-01` ``` { "name": "", "id": "", "etag": "", "type": "Microsoft.Network/virtualHubs/hubVirtualNetworkConnections", "properties": { "provisioningState": "Succeeded", "resourceGuid": "", "routingConfiguration": { "associatedRouteTable": { "id": "" }, "propagatedRouteTables": { "labels": [ "none" ], "ids": [ { "id": "" } ] }, "vnetRoutes": { "staticRoutes": [], "staticRoutesConfig": { "propagateStaticRoutes": false, "vnetLocalRouteOverrideCriteria": "Contains" } } }, "remoteVirtualNetwork": { "id": "" }, "allowHubToRemoteVnetTransit": true, "allowRemoteVnetToUseHubVnetGateways": true, "enableInternetSecurity": true, "connectivityStatus": "Connected" } } ``` cc: @juicybaba
Author: kuwas
Assignees: tadelesh
Labels: `Network`, `Service Attention`, `customer-reported`, `Mgmt`, `Network - Virtual Network`, `needs-team-attention`, `feature-request`, `CXP Attention`
Milestone: -
navba-MSFT commented 1 year ago

@aznetsuppgithub Could you please look into this request and update the status ? Thanks in advance.