search

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.69k stars 5.12k forks source link

Managed HSM: The status of LRO operation of `HSMSecurityDomain_Download` have be `Succeeded` not `Success` #23035

Open wuxu92 opened 1 year ago

wuxu92 commented 1 year ago

Hi, when i try to activate a manged HSM by API, the response of a LRO as below whick not obey the Azure

What i got fron LRO query:

{
    "status": "Success",
    "status_details": "The resource is active."
}

related operation in spec: https://github.com/Azure/azure-rest-api-specs/blob/ba9f30eed00b61ebb1ceedecd65a8ce82c81609b/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/securitydomain.json#L59-L66

but according to https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/async-operations

and from autorest SDK const definition, it only has the Succeeded not Success:

https://github.com/Azure/go-autorest/blob/ee71315119d4d7088d74ca9fcbc7301ce2ed2bc1/autorest/azure/async.go#L37-L42

const (
    operationInProgress string = "InProgress"
    operationCanceled   string = "Canceled"
    operationFailed     string = "Failed"
    operationSucceeded  string = "Succeeded"
)
ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

Issue Details
Hi, when i try to activate a manged HSM by API, the response of a LRO as below whick not obey the Azure What i got fron LRO query: ``` { "status": "Success", "status_details": "The resource is active." } ``` related operation in spec: https://github.com/Azure/azure-rest-api-specs/blob/ba9f30eed00b61ebb1ceedecd65a8ce82c81609b/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/securitydomain.json#L59-L66 but according to https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/async-operations and from autorest SDK const definition, it only has the `Succeeded` not `Success`: https://github.com/Azure/go-autorest/blob/ee71315119d4d7088d74ca9fcbc7301ce2ed2bc1/autorest/azure/async.go#L37-L42 ```go const ( operationInProgress string = "InProgress" operationCanceled string = "Canceled" operationFailed string = "Failed" operationSucceeded string = "Succeeded" ) ```
Author: wuxu92
Assignees: -
Labels: `KeyVault`, `Service Attention`, `needs-triage`
Milestone: -