search

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.64k stars 5.09k forks source link

Type of numExecutors is wrong in azure synapse activity SynapseNotebookActivity entity #23353

Open neerajanil opened 1 year ago

neerajanil commented 1 year ago

Description The type of numExecutors property in SynapseNotebookActivity is currently set to integer when it should be object. link

As can be seen from the screenshot below, from the synapse UI it is possible to set the numExecutors property to a dynamic expression: image This sets the value of numExecutors to the following, which is not an integer:

"numExecutors": {
    "value": "@pipeline().parameters.executors",
    "type": "Expression"
}

Impact Even though the API works, because the swagger specification is wrong the AutoRest generated code for the python SDK fails with de-serialization errors when trying to get/update/create any pipeline which has dynamic expression assigned to numExecutors property of SynapseNotebookActivity

Details of the bug on the python SDK caused by this swagger error can be found here

SaurabhSharma-MSFT commented 1 year ago

@neerajanil Thanks for your feedback! We will investigate and update as appropriate.

ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @wonner, @yanjungao718.

Issue Details
**Description** The type of numExecutors property in SynapseNotebookActivity is currently set to `integer` when it should be `object`. [link](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#L7449-L7453) As can be seen from the screenshot below, from the synapse UI it is possible to set the numExecutors property to a dynamic expression: ![image](https://user-images.githubusercontent.com/19595225/228102657-6efe5028-28a1-45fe-a22a-e7f72c4c3064.png) This sets the value of numExecutors to the following, which is not an `integer`: ```json "numExecutors": { "value": "@pipeline().parameters.executors", "type": "Expression" } ``` **Impact** Even though the API works, because the swagger specification is wrong the AutoRest generated code for the python SDK fails with de-serialization errors when trying to get/update/create any pipeline which has dynamic expression assigned to numExecutors property of SynapseNotebookActivity Details of the bug on the python SDK caused by this swagger error can be found [here](https://github.com/Azure/azure-sdk-for-python/issues/29613)
Author: neerajanil
Assignees: -
Labels: `bug`, `Service Attention`, `customer-reported`, `Synapse`
Milestone: -
wonner commented 1 year ago

@neerajanil Thanks for the feedback, it's a known issue, we will fix it ASAP.