Closed jamesvoongms closed 10 hours ago
Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/dnsresolver/armdnsresolver | https://apiview.dev/Assemblies/Review/4411017a9f714f28b210613e9b8d376f?revisionId=381e126aea34479bb620b9138e03068e |
.Net | Azure.ResourceManager.DnsResolver | https://apiview.dev/Assemblies/Review/4c218f3ee02849e7bf1a07da54cf1d61?revisionId=9ef8f1c6e4874209971b780f56e8d08c |
Swagger | Microsoft.Network | https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=c83648bcf6594238a26da775b3b106ba |
EDIT: Approved by breaking change team after emailing them
Hi team,
I have attached the private-repo PRs that have been signed off by ARM. The one remaining PR is currently causing a breaking change failure to be flagged due to changing from v2 to v5 of the common types usage. However looking at the common types, it looks like the only difference is the additional of the "format" key.
eg. The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 definitions.AzureEntityResource.properties.id Old: common-types/resource-management/v2/types.json#L14:9
/azp run
Your branch is out-of-date with base branch, please merge with base branch before requesting merge.
@ms-bogdan-rotaru , I have now merged in master, can you help approve?
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
The PR adds a new version for the DnsResolver API Spec, most notably adding a new json containing an upcoming feature for DNS Security Policy. It also changes the existing API spec to use common types v5 from v2.
Private-Repository PRs: https://github.com/Azure/azure-rest-api-specs-pr/pull/14085 https://github.com/Azure/azure-rest-api-specs-pr/pull/15020 https://github.com/Azure/azure-rest-api-specs-pr/pull/15737 https://github.com/Azure/azure-rest-api-specs-pr/pull/16191 https://github.com/Azure/azure-rest-api-specs-pr/pull/19685 (Currently in review)
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
. This should result in a new comment denoting aPR validation pipeline
has started and the checks should be updated after few minutes.