Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.62k stars 5.04k forks source link

DNS Resolver Release 2023-07-01-Preview with new DNS Security Policy feature #30707

Closed jamesvoongms closed 10 hours ago

jamesvoongms commented 3 days ago

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

The PR adds a new version for the DnsResolver API Spec, most notably adding a new json containing an upcoming feature for DNS Security Policy. It also changes the existing API spec to use common types v5 from v2.

Private-Repository PRs: https://github.com/Azure/azure-rest-api-specs-pr/pull/14085 https://github.com/Azure/azure-rest-api-specs-pr/pull/15020 https://github.com/Azure/azure-rest-api-specs-pr/pull/15737 https://github.com/Azure/azure-rest-api-specs-pr/pull/16191 https://github.com/Azure/azure-rest-api-specs-pr/pull/19685 (Currently in review)

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

Additional information

Viewing API changes For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

Getting help

openapi-pipeline-app[bot] commented 3 days ago

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.
openapi-pipeline-app[bot] commented 3 days ago

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/dnsresolver/armdnsresolver https://apiview.dev/Assemblies/Review/4411017a9f714f28b210613e9b8d376f?revisionId=381e126aea34479bb620b9138e03068e
.Net Azure.ResourceManager.DnsResolver https://apiview.dev/Assemblies/Review/4c218f3ee02849e7bf1a07da54cf1d61?revisionId=9ef8f1c6e4874209971b780f56e8d08c
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=c83648bcf6594238a26da775b3b106ba
jamesvoongms commented 3 days ago

EDIT: Approved by breaking change team after emailing them

Hi team,

I have attached the private-repo PRs that have been signed off by ARM. The one remaining PR is currently causing a breaking change failure to be flagged due to changing from v2 to v5 of the common types usage. However looking at the common types, it looks like the only difference is the additional of the "format" key.

eg. The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 definitions.AzureEntityResource.properties.id Old: common-types/resource-management/v2/types.json#L14:9

jamesvoongms commented 3 days ago

/azp run

azure-pipelines[bot] commented 3 days ago
Azure Pipelines successfully started running 3 pipeline(s).
ms-bogdan-rotaru commented 1 day ago

Your branch is out-of-date with base branch, please merge with base branch before requesting merge.

jamesvoongms commented 1 day ago

@ms-bogdan-rotaru , I have now merged in master, can you help approve?