Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.62k stars 5.04k forks source link

Microsoft.AVS grid events review #30735

Closed et1975 closed 1 day ago

et1975 commented 2 days ago

Data Plane API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Microsoft.AVS provider events converted to typespec had all the fields as optional, this PR makes some of the fields required.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Is this review for (select one):

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us! The [Azure API Review Board](https://aka.ms/azsdk/onboarding/restapischedule) is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our [wiki](https://aka.ms/azsdk/onboarding/restapischedule). * 💬 [Teams Channel](https://teams.microsoft.com/l/channel/19%3a3ebb18fded0e47938f998e196a52952f%40thread.tacv2/General?groupId=1a10b50c-e870-4fe0-8483-bf5542a8d2d8&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47) * 💌 [email](mailto://azureapirbcore@microsoft.com)
Click here for links to tools, specs, guidelines & other good stuff ### Tooling * [Open API validation tools](https://aka.ms/swaggertools) were run on this PR. Go here to see [how to fix errors](https://aka.ms/ci-fix) * [Spectral Linting](https://github.com/Azure/azure-api-style-guide/blob/main/README.md) ### Guidelines & Specifications * [Azure REST API Guidelines](https://aka.ms/azapi/guidelines) * [OpenAPI Style Guidelines](https://aka.ms/azapi/style) * [Azure Breaking Change Policy](https://aka.ms/AzBreakingChangesPolicy) ### Helpful Links * [Schedule a data plane REST API spec review](https://aka.ms/azsdk/onboarding/restapischedule)

Getting help

openapi-pipeline-app[bot] commented 2 days ago

Next Steps to Merge

Next steps that must be taken to merge this PR:
openapi-pipeline-app[bot] commented 2 days ago

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=4e1570e86e0a4072b7d153eed0dbd51b
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=2fd839d70ee141169e93d9ff2a7873f5
Swagger Microsoft.EventGrid https://apiview.dev/Assemblies/Review/8dab2e78889f4bf4a935473df37e62bf?revisionId=a362112d9c394ad2980259ded9c49e11
TypeSpec Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/bf48b2982ff74cd796f5900a221af2d5?revisionId=0b9eb44646cc461d92ca3f62acb3c18e