Closed noahdavis-msft closed 1 month ago
Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/azuredatatransfer/armazuredatatransfer | https://apiview.dev/Assemblies/Review/f0af8a39e91a4e0bae753b1f193ebeba?revisionId=073a3f0550a04d268fbb8b89924d5bfb |
JavaScript | @azure/arm-azuredatatransfer | https://apiview.dev/Assemblies/Review/3bda0c569a4b426698e685e51c964728?revisionId=0c76b61b9fad44c0aa17d745bd503e9b |
Java | azure-resourcemanager-azuredatatransfer | https://apiview.dev/Assemblies/Review/ecacad7845014c9081d89e8b2c9ec77d?revisionId=d3684473aab74dc79da910121898fe31 |
Swagger | Microsoft.AzureDataTransfer | https://apiview.dev/Assemblies/Review/28cada1a3c144c83b5a5e51d82207629?revisionId=28d7b46929054fd6b615660cb76b9c13 |
@microsoft-github-policy-service agree company="Microsoft"
@microsoft-github-policy-service agree company="Microsoft"
Please be aware that Breaking Change(Cross-Version)
check is failing. Also, please check the errors reported by the other required checks.
-Hello, I'm not sure what the LintDiff or azure-sdk-for-go are alerting on. Please advise. Thank you.-
/azp run
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureDataTransfer/connections/{connectionName}/flows/{flowName}/setPassphrase": {
why are these not being modelled as a patch on the flow object instead?
Refers to: specification/azuredatatransfer/resource-manager/Microsoft.AzureDataTransfer/stable/2024-09-27/azuredatatransfer.json:505 in 7bb4271. [](commit_id = 7bb4271f362c9e7ae75728630f24664a50ad9766, deletion_comment = False)
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureDataTransfer/connections/{connectionName}/flows/{flowName}/setPassphrase": {
why are these not being modelled as a patch on the flow object instead?
Refers to: specification/azuredatatransfer/resource-manager/Microsoft.AzureDataTransfer/stable/2024-09-27/azuredatatransfer.json:505 in 7bb4271. [](commit_id = 7bb4271, deletion_comment = False)
Most of these values are customer-provided non-Azure endpoints, addresses, ports, and secrets. Think in a datacenter or office building. Our organization considers these as secrets, and therefor does not store them in the Flow object, but we do store them in KeyVaults behind the scenes.
While the set
methods can be replaced with patch operations, the get
s cannot. For uniformity and clarity to our partner teams we opt'd to create getter/setter methods for both.
/azp run
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
. This should result in a new comment denoting aPR validation pipeline
has started and the checks should be updated after few minutes.