Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.68k stars 5.11k forks source link

Adding sitecertificate resource type to Microsoft.Web RP #31446

Open gargimitra opened 1 week ago

gargimitra commented 1 week ago

Adding a new resource type "sites/certificates" in Microsoft.Web swagger.

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

Additional information

Viewing API changes For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

Getting help

openapi-pipeline-app[bot] commented 1 week ago

Next Steps to Merge

Next steps that must be taken to merge this PR:
openapi-pipeline-app[bot] commented 1 week ago

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/c727c406be7543caa08a79ce56dda352?revisionId=ea605a1f9de24b6ba46e6d243d69e5f2
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=098cf88983474717ba7c9aabdeb3738f
gargimitra commented 1 week ago

@gargimitra please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Microsoft"]

gargimitra commented 1 week ago

@microsoft-github-policy-service agree company="your company" @microsoft-github-policy-service agree company="Microsoft"

razvanbadea-msft commented 3 days ago
"Certificate": {

if this was moved to common definitions why are you not removing them from here?


Refers to: specification/web/resource-manager/Microsoft.Web/stable/2024-11-01/Certificates.json:310 in 15194a8. [](commit_id = 15194a8e8ace47f09e8fdc8eefdfff17fa660174, deletion_comment = False)

gargimitra commented 3 days ago
"Certificate": {

if this was moved to common definitions why are you not removing them from here?

Refers to: specification/web/resource-manager/Microsoft.Web/stable/2024-11-01/Certificates.json:310 in 15194a8. [](commit_id = 15194a8, deletion_comment = False)

Removed