Open bjqian opened 1 week ago
"maxInboundMessageBytes": {
if there is a 1GB as default why did you not set it? like you added for aggregationWindowInSeconds
Refers to: specification/signalr/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/signalr.json:3743 in beb58ba. [](commit_id = beb58bae6ea20745963ae7853c3f034e46469f15, deletion_comment = False)
"description": "Gets or sets the Keep-Alive Interval. Optional to set.\r\nValue is in seconds.\r\nThe default value is 15 seconds.\r\nCustomers should set this value to a shorter period if they want the service to send keep-alive messages more frequently, \r\nensuring timely checks of the connection status.\r\nConversely, customers can set this value to a longer period if they want the service to send keep-alive messages less frequently, \r\nreducing network traffic, but note that it may take longer to detect a disconnection.\r\nThis interval ensures that the connection is maintained by sending periodic keep-alive messages to the client.",
same thing about adding also a default
Refers to: specification/signalr/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/signalr.json:3044 in beb58ba. [](commit_id = beb58bae6ea20745963ae7853c3f034e46469f15, deletion_comment = False)
"description": "Rules to control the client traffic",
you can specify in the description that you cant add more than 10
Refers to: specification/signalr/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/signalr.json:2157 in beb58ba. [](commit_id = beb58bae6ea20745963ae7853c3f034e46469f15, deletion_comment = False)
"maxInboundMessageBytes": {
same comment in this file about default attribute
Refers to: specification/webpubsub/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/webpubsub.json:3776 in beb58ba. [](commit_id = beb58bae6ea20745963ae7853c3f034e46469f15, deletion_comment = False)
"description": "Gets or sets the Keep-Alive Interval. Optional to set.\r\nValue is in seconds.\r\nThe default value is 15 seconds.\r\nCustomers should set this value to a shorter period if they want the service to send keep-alive messages more frequently, \r\nensuring timely checks of the connection status.\r\nConversely, customers can set this value to a longer period if they want the service to send keep-alive messages less frequently, \r\nreducing network traffic, but note that it may take longer to detect a disconnection.\r\nThis interval ensures that the connection is maintained by sending periodic keep-alive messages to the client.",
same thing about adding also a default
Refers to: specification/signalr/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/signalr.json:3044 in beb58ba. [](commit_id = beb58ba, deletion_comment = False)
Hi @razvanbadea-msft . In this PR review , I found a new rule: It's telling us to remove the swagger default value in the patch body. I'm confused whether or not we should mark the default value in the swagger. 😂
"description": "Gets or sets the Keep-Alive Interval. Optional to set.\r\nValue is in seconds.\r\nThe default value is 15 seconds.\r\nCustomers should set this value to a shorter period if they want the service to send keep-alive messages more frequently, \r\nensuring timely checks of the connection status.\r\nConversely, customers can set this value to a longer period if they want the service to send keep-alive messages less frequently, \r\nreducing network traffic, but note that it may take longer to detect a disconnection.\r\nThis interval ensures that the connection is maintained by sending periodic keep-alive messages to the client.",
same thing about adding also a default Refers to: specification/signalr/resource-manager/Microsoft.SignalRService/preview/2024-10-01-preview/signalr.json:3044 in beb58ba. [](commit_id = beb58ba, deletion_comment = False)
Hi @razvanbadea-msft . In this PR review , I found a new rule: It's telling us to remove the swagger default value in the patch body. I'm confused whether or not we should mark the default value in the swagger. 😂
for patch operations: A recommended way is to define a new model that only contains the patchable properties to replace the original parameter in request body. - https://github.com/Azure/azure-openapi-validator/blob/main/docs/patch-body-parameters-schema.md#how-to-fix
are those properties patchable or can be excluded from it?
Hi @razvanbadea-msft .
Thanks for the clarification! I understand the recommended approach is to use a separate model for patch if a model contains "default/required" properties.
Let me elaborate a bit on the issue:
Yes, those properties are pachable. However, the two properties in question were introduced in a model from a previous API version. Switching to a new model could potentially break existing client code.
In our Resource Provider, the actual behavior for default value in the comment is as follows:
In this way, we could avoid introducing "swagger default" in the client side.
Thank you again for highlighting this issue! Please let us know if you'd like more details or further clarification.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
. This should result in a new comment denoting aPR validation pipeline
has started and the checks should be updated after few minutes.