Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.69k stars 5.11k forks source link

lijiaq hybridcompute microsoft.hybrid compute 2024 11 10 preview #31553

Open jiaqi-beep opened 1 week ago

jiaqi-beep commented 1 week ago

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

Additional information

Viewing API changes For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

Getting help

openapi-pipeline-app[bot] commented 1 week ago

Next Steps to Merge

Next steps that must be taken to merge this PR:
openapi-pipeline-app[bot] commented 1 week ago

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/cc99eb4c91204d199d8e40aed71bc06e?revisionId=8271a7b5547945119c794324462ea165
Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/b79886348ebe497b9ddc99d286cb6e99?revisionId=7dca2b63ed8a4a86b61d1cef4bacdf23
JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/bd79793b6b53409d8de21847c605dc64?revisionId=42d81c29f2d34b42ab0beede7cd0fcfe
.Net Azure.ResourceManager.HybridCompute There is no API change compared with the previous version
Python azure-mgmt-hybridcompute https://apiview.dev/Assemblies/Review/4d8650fb76954c6ba3f15e1781007dd9?revisionId=bb9d4a3b352a41b8b7b402632b025f0b
jiaqi-beep commented 1 week ago

This preview has been signed off, but we want to include the change in a separate preview instead https://github.com/Azure/azure-rest-api-specs/pull/30656

azure-sdk commented 1 week ago

API change check

APIView has identified API level changes in this PR and created following API reviews.

preview

jiaqi-beep commented 1 week ago

@tadelesh , @qiaozha , @weidongxu-microsoft , @msyyc , can you help check why azure-sdk-for-* checks all failed?

jiaqi-beep commented 1 day ago

breaking change previously approved in #29560

ms-bogdan-rotaru commented 1 day ago

I'm comparing HybridCompute.json specification from this PR with the base spec at this path: https://github.com/Azure/azure-rest-api-specs/blob/8e0591326d2eb5e0dcb8b284377de87eb1f105f4/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2024-07-31-preview/HybridCompute.json

There are some differences on using the common types, can you please check?

ms-bogdan-rotaru commented 1 day ago

Additionally - you pushed some more changes in the last commit after the PR has been signed off.

jiaqi-beep commented 17 hours ago

Additionally - you pushed some more changes in the last commit after the PR has been signed off.

yep. It was signed off before it was ready

jiaqi-beep commented 17 hours ago

@ms-bogdan-rotaru We made the change to use v3 common types in these PR, please check. This was to fix some breaking change check fails. https://github.com/Azure/azure-rest-api-specs/pull/30546 <-- https://github.com/Azure/azure-rest-api-specs/pull/31063