jijohn14 commented 4 days ago

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[x] Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app[bot] commented 4 days ago

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app[bot] commented 4 days ago

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/77a1e1c7ff4c495e8e1c9cf369fdf74a?revisionId=a4e87c494d75417da3de205986846ea3
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=a777c9581a744f6ab9e88abaa8c1262c
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=7e7ac5bdb1154f28a1fab1af8d19cc8d
Python	azure-mgmt-appcontainers	https://apiview.dev/Assemblies/Review/1693ff33eb9c4a86a7684539954c49cf?revisionId=adb9c7fa8baa4aa7af241c368c1cdbaa

jijohn14 commented 4 days ago

We missed to include https://github.com/Azure/azure-rest-api-specs/pull/31285 to https://github.com/Azure/azure-rest-api-specs/pull/31066

azure-sdk commented 4 days ago

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.App

Juliehzl commented 4 days ago

We already get arm sign off in https://github.com/Azure/azure-rest-api-specs/pull/31285. The api version 2024-10-02-preview is just merged in https://github.com/Azure/azure-rest-api-specs/pull/31066 and never release any SDK released. specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ManagedEnvironmentsMaintenanceConfigurations.json is also newly added in 2024-10-02-preview api version, so there should be no breaking change.

Juliehzl commented 3 days ago

/azp run

azure-pipelines[bot] commented 3 days ago

Azure Pipelines successfully started running 3 pipeline(s).

Azure / azure-rest-api-specs

[Microsoft.App] Remove unsupported values from unreleased MaintenanceConfiguration resource type #31583