Open ZianWang02 opened 2 days ago
VersioningReviewRequired
).ARMReview
). This PR must get ARMSignedOff
label from an ARM reviewer.ARMChangesRequested
label. Please address or respond to feedback from the ARM API reviewer. ARMChangesRequested
label. WaitForARMFeedback
label. write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.Swagger BreakingChange
has failed. To unblock this PR, follow the process at aka.ms/brch.Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/cdn/armcdn | https://apiview.dev/Assemblies/Review/5e345519a8864b018f9aae9fb7ba934c?revisionId=b8e431e885344e38942b56bfd697d052 |
JavaScript | @azure/arm-cdn | https://apiview.dev/Assemblies/Review/d03c7f4c0d164abd85030a921f78f9ad?revisionId=25ab748721de46b7ad8a7f656a053020 |
Java | azure-resourcemanager-cdn-generated | https://apiview.dev/Assemblies/Review/a857fa609d3c43b09808544a49c0693b?revisionId=eb5354d7244144ff9931807d5bb83d87 |
Python | azure-mgmt-cdn | https://apiview.dev/Assemblies/Review/554f619b5bce4305ab34ed93bfc66da9?revisionId=70101e12d5ce4592a014d888090f74d4 |
API change check
APIView has identified API level changes in this PR and created following API reviews.
/azp run
Hi ARM DRI, our deployment version feature is controlled by the feature flag and not used by any customer yet. We would like to update the swagger for the 2024-06-01-preview version to update the definition. Can we add the tag "Versioning-Approved-BugFix" to bypass the breaking change check? Here is the changes for this PR:
@ZianWang02 The breaking change label has to be added by the Breaking Change Review board - aka.ms/brch Please get this approval first and get put the PR back in the queue for API review.
Hi @ms-bogdan-rotaru, is it possible for us to bypass the Breaking Change review because the API related to the Microsoft.Cdn/profiles/deploymentversions is controlled by the feature flag and not opened to any customer yet?
Please follow the instructions and details provided at https://aka.ms/brch. Only the members of Breaking Change approval board can take these decisions.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
. This should result in a new comment denoting aPR validation pipeline
has started and the checks should be updated after few minutes.