Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.69k stars 5.11k forks source link

Add contract changes to ARM repo for MFE inference group status #31606

Open ritujhams opened 2 days ago

ritujhams commented 2 days ago

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

Additional information

Viewing API changes For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

Getting help

openapi-pipeline-app[bot] commented 2 days ago

Next Steps to Merge

Next steps that must be taken to merge this PR:
openapi-pipeline-app[bot] commented 2 days ago

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=11e9cfdd826046a383c30d99caddbf54
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=76e5f42d534d4cc39f83977bcdbfa3cf
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=866f37738fa64b638c009036f1e42cd0
.Net Azure.ResourceManager.MachineLearning https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=9a49c84c9fb24801946c507d1794472b
azure-sdk commented 2 days ago

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.MachineLearningServices

ritujhams commented 2 days ago

Justification for the change - This is a new product offering and we made changes to the status api to fit user needs and we want this change to go in before customers start using the status api heavily.

Also this "Get Group Status" api is not being actively used in prod right now. Attached below is the result for last one month for prod regions. There are 0 results.

https://dataexplorer.azure.com/clusters/viennaweu/databases/Vienna?query=H4sIAAAAAAAAA3VTa2%2FTMBT9vl%2Fh5Usb5K5dmAQUhrS1EZvY1tEHEkxVZZK71ii1PdvZqMSP5%2BbpdClf8ri%2B5%2Fj43OMELPmaGitHCT5Bk3PSeeYgBLNgbOfjUYINKxDxnG8BF2OsW%2FzsBoPgrHd62jv9MA%2BC4dm74eD9T79sN5Zpexgw6AVBC4D0SnJhV4LlmE6571rLVL0uKimT1zUNTynKXV3HZXEhuBSTx4skuZFr0%2FW%2B50fyKPGuxSNoEBGMQSVytwVhPf%2Bo3ydRYUC36YZ%2FgvLZL2agpvBPDjAg%2Fi952WCZhOL5DsUZxSIgx5EUlnFhiKfSJPGOqq57DRE3kHk0s2yryOema0zE7Y5P5%2FUcappRQZ%2BN7Zx4vBLWi2tlPaa42xZ1GbYGsmEmcyKSWy7WlXtkMb0Zut6F5uS4bLRersmVeLsUMcH07nV1dLAKzNjUBJAy1aJB0Zqh%2FfniATUxJJbdSnyZQ8v9LVjWb%2BstrXHO9DfAErtxnQV8DRb9RnWOfFr4g%2BHKezh%2F7DYCd4zOM5wtbaQQc9bzfOLGjZnNUpE3O2Kc71bZXXcv%2Fz6RGlNUVHJQHaK9vhZLfTFyhnrLGl2vt5DunuXQL9nvPtZ15FGHPxa1oDFGSWFghNPAi2czbV2jEl49y7zRzvCh4z%2B8XdLOEt%2BDpd9kGaeaWbyuyPB%2F7FmNRfWKaePC%2FMLthrwh3jSc3U%2FuZuFqNBmHwwdvX563JOPF9GJ%2BPbnL1upNsT4Nvy3C2Xx1FV6Mw%2BnMK8iK2uVk%2FKPgymd7KeNdASn32seURQcqBJSobPBKy98Q2db1pi5ltBoddZOge4mg5MpadQt2IzFq1VFo87y0IZg2dVCMOq28%2BwfK5CI4%2FgUAAA%3D%3D

let KustoCluster = 'viennatest'; let _endTime = datetime(2024-11-19T22:47:08Z); let _startTime = datetime(2024-10-22T22:47:08Z); let endpoint_name = ''; let group_name = ''; let pool_name = ''; let request_Id = ''; UnionOfAllLogs("Vienna", "InferenceDeployment") // cluster(KustoCluster).database("Vienna").InferenceDeployment //| where EnvNamespace !contains "pull" | where PreciseTimeStamp > _startTime and PreciseTimeStamp <= _endTime | where Container == "inference-deployment-api" | where message has "Incoming request URL:" | where Uri !has "Int" and Uri !has "int" and Uri !has "canary" and Uri !has "Canary" and Uri !has "eastus2euap" and Uri !has "centraluseuap" | where Uri !has "deltaModels" | where Uri !has "/meta/" and Uri !has "inferencedeployment/health" and Uri has "/getStatus" | where RequestId has iif(request_Id != "all", request_Id, "-") | where PoolName != "" | where isempty(endpoint_name) or EndpointName contains endpoint_name | where isempty(pool_name) or PoolName contains pool_name | where isempty(group_name) or GroupName contains group_name //| extend ResponseCode = toint(split(split(message,':[')[3],']')[0]) //| extend Duration = split(split(message,':[')[4],']')[0] | parse message with "RESPONSE_CODE:[" ResponseCode "] DURATION:[" Duration "] REQUEST_HEADERS" "REQUEST_BODY:[" RequestBody "] RESPONSE_HEADERS" * "RESPONSE_BODY:[" ResponseBody "]" | project PreciseTimeStamp, RequestId,PoolName, GroupName, EndpointName, HttpMethod, Duration,ResponseCode,RequestBody,ResponseBody,Uri, message

ms-bogdan-rotaru commented 1 day ago

Please get the breaking change approval first and after that put the PR back in the review queue.

ritujhams commented 11 hours ago

/azp run

azure-pipelines[bot] commented 11 hours ago
Azure Pipelines successfully started running 3 pipeline(s).