Open ritujhams opened 2 days ago
ARMReview
). This PR must get ARMSignedOff
label from an ARM reviewer.WaitForARMFeedback
).Automated merging requirements met
has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagramLanguage | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/machinelearning/armmachinelearning | https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=11e9cfdd826046a383c30d99caddbf54 |
JavaScript | @azure/arm-machinelearning | https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=76e5f42d534d4cc39f83977bcdbfa3cf |
Java | azure-resourcemanager-machinelearning | https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=866f37738fa64b638c009036f1e42cd0 |
.Net | Azure.ResourceManager.MachineLearning | https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=9a49c84c9fb24801946c507d1794472b |
API change check
APIView has identified API level changes in this PR and created following API reviews.
Justification for the change - This is a new product offering and we made changes to the status api to fit user needs and we want this change to go in before customers start using the status api heavily.
Also this "Get Group Status" api is not being actively used in prod right now. Attached below is the result for last one month for prod regions. There are 0 results.
let KustoCluster = 'viennatest'; let _endTime = datetime(2024-11-19T22:47:08Z); let _startTime = datetime(2024-10-22T22:47:08Z); let endpoint_name = ''; let group_name = ''; let pool_name = ''; let request_Id = ''; UnionOfAllLogs("Vienna", "InferenceDeployment") // cluster(KustoCluster).database("Vienna").InferenceDeployment //| where EnvNamespace !contains "pull" | where PreciseTimeStamp > _startTime and PreciseTimeStamp <= _endTime | where Container == "inference-deployment-api" | where message has "Incoming request URL:" | where Uri !has "Int" and Uri !has "int" and Uri !has "canary" and Uri !has "Canary" and Uri !has "eastus2euap" and Uri !has "centraluseuap" | where Uri !has "deltaModels" | where Uri !has "/meta/" and Uri !has "inferencedeployment/health" and Uri has "/getStatus" | where RequestId has iif(request_Id != "all", request_Id, "-") | where PoolName != "" | where isempty(endpoint_name) or EndpointName contains endpoint_name | where isempty(pool_name) or PoolName contains pool_name | where isempty(group_name) or GroupName contains group_name //| extend ResponseCode = toint(split(split(message,':[')[3],']')[0]) //| extend Duration = split(split(message,':[')[4],']')[0] | parse message with "RESPONSE_CODE:[" ResponseCode "] DURATION:[" Duration "] REQUEST_HEADERS" "REQUEST_BODY:[" RequestBody "] RESPONSE_HEADERS" * "RESPONSE_BODY:[" ResponseBody "]" | project PreciseTimeStamp, RequestId,PoolName, GroupName, EndpointName, HttpMethod, Duration,ResponseCode,RequestBody,ResponseBody,Uri, message
Please get the breaking change approval first and after that put the PR back in the review queue.
/azp run
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the `Generated ApiView` comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the [suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
. This should result in a new comment denoting aPR validation pipeline
has started and the checks should be updated after few minutes.