Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.68k stars 5.1k forks source link

`Microsoft.MachineLearningServices` associated resource IDs in workspace are not preserving proper casing #8323

Open ArcturusZhang opened 4 years ago

ArcturusZhang commented 4 years ago

REST API URL:

PUT /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/Microsoft.MachineLearningServices/workspaces/test-Workspace?api-version=2019-11-01 HTTP/1.1

Body:

{
    "identity": {
        "type": "SystemAssigned"
    },
    "location": "westus",
    "properties": {
        "keyVault": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/Microsoft.KeyVault/vaults/testVault",
        "applicationInsights": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/microsoft.insights/components/test-AppInsights",
        "storageAccount": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/Microsoft.Storage/storageAccounts/teststorageaccount"
    },
    "sku": {
        "name": "Basic"
    },
    "tags": {}
}

After the creation complete, perform a GET request:

GET /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/Microsoft.MachineLearningServices/workspaces/test-Workspace?api-version=2019-11-01 HTTP/1.1

Response:

{
    "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-resources/providers/Microsoft.MachineLearningServices/workspaces/test-Workspace",
    "name": "test-workspace",
    "type": "Microsoft.MachineLearningServices/workspaces",
    "location": "westus",
    "tags": {},
    "etag": null,
    "properties": {
        "friendlyName": "",
        "description": "",
        "creationTime": "2020-02-06T06:54:56.5115492+00:00",
        "storageAccount": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test-resources/providers/microsoft.storage/storageaccounts/teststorageaccount",
        "containerRegistry": null,
        "keyVault": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test-resources/providers/microsoft.keyvault/vaults/testvault",
        "applicationInsights": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test-resources/providers/microsoft.insights/components/test-appinsights",
        "hbiWorkspace": false,
        "tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47",
        "workspaceId": "d4cfc4fe-1cd7-4881-bc8a-83ca8aaff7cb",
        "subscriptionState": null,
        "subscriptionStatusChangeTimeStampUtc": null,
        "discoveryUrl": "https://westus.experiments.azureml.net/discovery"
    },
    "identity": {
        "type": "SystemAssigned",
        "principalId": "539eb439-c316-49af-85af-e462e2ed0b90",
        "tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
    },
    "sku": {
        "name": "Basic",
        "tier": "Basic"
    }
}

The IDs in the response lost all their casing, for instance:

ArcturusZhang commented 4 years ago

Hi @zhaomuzhi @drajput please have a look at this issue.

weidongxu-microsoft commented 4 years ago

@ArcturusZhang

I think all resource id in Azure is case insensitive. So there seems not very important to preserve case.

ArcturusZhang commented 4 years ago

@ArcturusZhang

I think all resource id in Azure is case insensitive. So there seems not very important to preserve case.

Usually, terraform will require the service to preserve cases.

akning-ms commented 4 years ago

@weidongxu-microsoft what is a conclusion? should we assign to service team to address?

ghost commented 4 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc

rastala commented 4 years ago

@ArcturusZhang Thank you for your feedback. This bug has been reported to our engineering team.

gro1m commented 3 years ago

Hi @rastala @v-strudm-msft This is now 15 months old - has there been some progress here? I want to bring machine learning resources up to speed with Terraform, but everything is a bit outdated. And Microsoft starts to also give guarantees that Terraform runs stably and I think keeping up-to-date and continuous versioning are a fundamental concern in software engineering. I do not like to see that things get postponed over months, as like this one will never have feature-completeness (one is always behind!) and never have stability. FYI: @ArcturusZhang, @favoretti

deeikele commented 2 months ago

@gro1m @rastala This issue has been fixed. @rastala are you able to close it?