[DataLake]: Update Swagger objects to have proper inheritance

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.

MIT License

2.63k stars 5.07k forks source link

[DataLake]: Update Swagger objects to have proper inheritance #928

Closed begoldsm closed 7 years ago

begoldsm commented 7 years ago

Need explicit inheritance for (flow is each lower object is "AllOf" the one above it, in the nested lists)

JobInformation
- BaseJobInformation
- SubmitJobResponse
- JobInformation
- SubmitJobParameters (maybe)
Account (adla and adls)
- ListAccount
- Account

begoldsm commented 7 years ago

@amarzavery can you assign this to me, I can't modify assignees.

kirthik commented 7 years ago

@begoldsm - Could you provide an update on this issue? Is it fixed?

begoldsm commented 7 years ago

@kirthick this is not yet fixed. This is a nice to have clean up task that will result in a lot of breaking changes to subsequent releases of the sdk. This is requirement is only to make our strict swagger validation tests work so that an object that is returned doesn't have missing "required" properties.

I will sync with PM to prioritize this and reply back here with an eta

begoldsm commented 7 years ago

@veronicagg and @kirthik this should be resolved by PR #1429 can you confirm and close this if so?