search

Azure / azure-ruby-asm-core

Azure Ruby SDK Service Management Core HTTP
6 stars 32 forks source link

Changed 'nokogiri' back to runtime dependency with version >= 1.6. #43

Closed katmsft closed 7 years ago

katmsft commented 7 years ago

This can resolve the issue where bundler failed to recognize Nokogiri as a installed dependency. However, this will cause customers who is currently using ruby version 1.9.3~2.2.0 to not be able to install this gem, unless a compatible version of Nokogiri is installed before azure-asm-core.

msftclas commented 7 years ago

@katmsft, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

katmsft commented 7 years ago

Fail with Ruby version 2.2.0 is a known issue reported in #5341 in bundler’s repo. The issue was fixed in bundler 1.14.1, and won’t happen for 1.14.0 if ruby version is newer than 2.2.4. If you change your script of gem install bundler -v 1.14.0 to gem install bundler -v 1.14.1 the problem should be fixed. I have updated the PR accordingly.