Handle Null Logic - Githubissues

Azure / azure-saas

The Azure SaaS Development Kit (ASDK) provides a reference architecture, deployable reference implementation and tools to help developers, startups, ISVs and Enterprises deliver their applications as a SaaS service. A platform for platform creators.

https://aka.ms/azuresaasdevkit

339 stars 294 forks source link

Handle Null Logic #164

Closed julian-mcnichols closed 2 years ago

julian-mcnichols commented 2 years ago

NOTE: Depends on https://github.com/Azure/azure-saas/pull/162

Enforce null warnings in both SaasApp and SignupAdmin app
Convert model values to nullable where no obvious assumption on instantiation can be made
Ensure subsequent service logic accounts for null checking

julian-mcnichols commented 2 years ago

Looks pretty good but still a few warnings in OnboardingWorkflow.cs. Also its spelled wrong.

What's misspelled? Both Onboarding and Workflow there are correct. Are you referring to some other word in the class?

codebytes commented 2 years ago

The filename :) src/Saas.SignupAdministration/Saas.SignupAdministration.Web/Services/OnbordingWorkflow.cs