Azure / azure-saas

The Azure SaaS Development Kit (ASDK) provides a reference architecture, deployable reference implementation and tools to help developers, startups, ISVs and Enterprises deliver their applications as a SaaS service. A platform for platform creators.
https://aka.ms/azuresaasdevkit
326 stars 239 forks source link

No module named 'ruamel' #233

Closed fbomb111 closed 10 months ago

fbomb111 commented 10 months ago

Describe the bug

Traceback (most recent call last): File "/asdk/src/Saas.Lib/Deployment.Script.Modules/patch-github-workflow.py", line 4, in from ruamel.yaml import YAML ModuleNotFoundError: No module named 'ruamel'

To Reproduce

Installed the Sass.IdentityProvider module first. Success. Then I was following the Saas.Permissions install guide. Which is to run:

sudo chmod +x setup.sh ./setup.sh ./run.sh

Expected behavior Expected no error.

Desktop (please complete the following information):

1iveowl commented 10 months ago

Try to add the missing module to the DockerFiles in directory and rebuild the container: https://github.com/Azure/azure-saas/tree/main/src/Saas.Lib/Deployment.Container

You maybe need to add python3-ruamel.yaml to the list of things to install - i.e.,:


FROM ubuntu:22.04

RUN apt-get update && apt-get install -y \
    curl \
    dnsutils \
    python3-pip \
    jq \
    sudo \
    libicu-dev \
    uuid-runtime \
    zip \
    dos2unix \
    python3-ruamel.yaml \
    && curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash

I’m not sure why you are seeing this error. Could be Apple Silicon related. Could also be that something have changed in the dependancies of the other modules. In any case let us know if this works and we can look into updating the scrips/dockerfile accordingly.

fbomb111 commented 10 months ago

This worked great! No error. I was not sure where to add the dependency myself so thanks for the help.

1iveowl commented 10 months ago

OK. Thanks for confirming and glad it works now.