Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181 stars 126 forks source link

possible race condition in curl gloabalclean test #4217

Open gearama opened 1 year ago

gearama commented 1 year ago

S:\src\azure-sdk-for-cpp\sdk\core\azure-core\test\ut\azure_libcurl_core_main_test.cpp line 54 assert fails with 0 elements in the list. It failed only once the only error was the assert was expecting 1 and got 0. i might be wrong but there might be a race condition that causes the connection to not be moved back to the pool. a cursory look at the code that deals with the connection pool and connection poll index had some mutexes and timeouts on said mutexes.

gearama commented 1 year ago

Assigning to larry as he might have some insight in these issue

ahsonkhan commented 1 year ago

S:\src\azure-sdk-for-cpp\sdk\core\azure-core\test\ut\azure_libcurl_core_main_test.cpp line 54 assert fails with 0 elements in the list.

https://github.com/Azure/azure-sdk-for-cpp/blob/b372b85f5b1f5b0e8c021d2b07ab198f9b1fe9cc/sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp#L50-L54