search

Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
174 stars 124 forks source link

Add version resources to Azure SDK binaries when building on Windows (WAS: Allow specifying binary version for Windows builds) #5158

Open avivanoff opened 10 months ago

avivanoff commented 10 months ago

Original request:

When building on Windows it would be nice to have the ability to specify version info.

When an Azure SDK package is built as a shared binary (DLL) on Windows, add a version resource which reflects the version of the package.

LarryOsterman commented 10 months ago

Could you explain "it would be nice to have the ability to specify version info" a bit more? Do you mean the application manifest? The SDK version preprocessor definitions? Something else? What is a "binary version" in this context?

The SDK source code is intentionally windows version agnostic (as much as is feasible).

avivanoff commented 10 months ago

Conditionally include rc file when targeting Windows.

LarryOsterman commented 10 months ago

Conditionally include rc file when targeting Windows.

Ah - you want to add a resource file when building the SDK as a shared library (dll).

That makes a certain amount of sense. If you don't mind, let me edit the text to reflect what I believe is your request.

avivanoff commented 10 months ago

Yes, thank you.

avivanoff commented 3 months ago

@LarryOsterman, any updates? Seems like should be easy enough change.