Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
170 stars 118 forks source link

Cleaned up Azure::Core::Context API surface #5676

Open LarryOsterman opened 1 month ago

LarryOsterman commented 1 month ago

Updated semantics of Azure::Core::Context

  1. ApplicationContext is deprecated.
  2. A new constructor for Context is added to enable directly creating a context with a deadline.

Updated documentation for Azure::Core::Context to express the current semantics.

Also generalized documentation cleanup.

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

LarryOsterman commented 1 month ago

/azp run cpp - storage - ci

azure-pipelines[bot] commented 1 month ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
LarryOsterman commented 1 month ago

/azp run cpp - keyvault - ci

azure-pipelines[bot] commented 1 month ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
LarryOsterman commented 1 month ago

/azp run cpp - tables - ci

azure-pipelines[bot] commented 1 month ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
LarryOsterman commented 1 month ago

/azp run cpp - identity - ci

azure-pipelines[bot] commented 1 month ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
LarryOsterman commented 3 weeks ago

Ping. At this point, I'm happy with the design and would appreciate any feedback.

Thanks!

LarryOsterman commented 3 weeks ago

Ping :).

LarryOsterman commented 3 weeks ago

Ping :).

LarryOsterman commented 2 weeks ago

Ping again. I would like to get this in soon, so would appreciate feedback.

LarryOsterman commented 1 week ago

Ping again.

ahsonkhan commented 1 week ago

I'll make time to review and page-back the conversation tomorrow, so I can provide more meaningful feedback.

From a PR review perspective, I trust that you've got the specifics well. The higher order question, that would be great for us to get consensus on, is about the design and end user experience. A PR conversation is likely not the best medium for that discussion (will discuss offline).

LarryOsterman commented 1 week ago

I'll make time to review and page-back the conversation tomorrow, so I can provide more meaningful feedback.

From a PR review perspective, I trust that you've got the specifics well. The higher order question, that would be great for us to get consensus on, is about the design and end user experience. A PR conversation is likely not the best medium for that discussion (will discuss offline).

Agreed that PR comments aren't the right place for this, but to help frame the discussion: What parts of this change do you feel require additional discussion?

LarryOsterman commented 4 days ago

Ping.

LarryOsterman commented 2 days ago

/azp run cpp - core - ci

azure-pipelines[bot] commented 2 days ago
Azure Pipelines successfully started running 1 pipeline(s).
LarryOsterman commented 2 days ago

Ping. I believe that as of the discussion on 6/27, this should be the implementation of the final design.

LarryOsterman commented 2 days ago

/azp run cpp - storage - ci

azure-pipelines[bot] commented 2 days ago
Azure Pipelines successfully started running 1 pipeline(s).
LarryOsterman commented 2 days ago

Ping. Waiting on feedback from @EmmaZhu, @Jinming-Hu , @RickWinter , @ahmadmsft, @gkostal , @anilba06 , @antkmsft , @vinjiang , and @microzchang.

This PR cannot proceed until every one of you signs off on it.