Open LarryOsterman opened 1 month ago
/azp run cpp - storage - ci
/azp run cpp - keyvault - ci
/azp run cpp - tables - ci
/azp run cpp - identity - ci
Ping. At this point, I'm happy with the design and would appreciate any feedback.
Thanks!
Ping :).
Ping :).
Ping again. I would like to get this in soon, so would appreciate feedback.
Ping again.
I'll make time to review and page-back the conversation tomorrow, so I can provide more meaningful feedback.
From a PR review perspective, I trust that you've got the specifics well. The higher order question, that would be great for us to get consensus on, is about the design and end user experience. A PR conversation is likely not the best medium for that discussion (will discuss offline).
I'll make time to review and page-back the conversation tomorrow, so I can provide more meaningful feedback.
From a PR review perspective, I trust that you've got the specifics well. The higher order question, that would be great for us to get consensus on, is about the design and end user experience. A PR conversation is likely not the best medium for that discussion (will discuss offline).
Agreed that PR comments aren't the right place for this, but to help frame the discussion: What parts of this change do you feel require additional discussion?
Ping.
/azp run cpp - core - ci
Ping. I believe that as of the discussion on 6/27, this should be the implementation of the final design.
/azp run cpp - storage - ci
Ping. Waiting on feedback from @EmmaZhu, @Jinming-Hu , @RickWinter , @ahmadmsft, @gkostal , @anilba06 , @antkmsft , @vinjiang , and @microzchang.
This PR cannot proceed until every one of you signs off on it.
Updated semantics of
Azure::Core::Context
ApplicationContext
is deprecated.Updated documentation for
Azure::Core::Context
to express the current semantics.Also generalized documentation cleanup.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.