This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
Refactored still more uAMQP only constructs out of Rust AMQP codebase (Link specifically).
Implemented basic AMQP message sender implementation (options don't currently work).
Added CBS deterministic close and message sender close methods.
This pull request to sdk/core/azure-core-amqp includes changes to improve the modularity and maintainability of the codebase. The most important changes involve reorganizing file inclusions, conditional compilation adjustments, and some code refactoring.
These changes collectively aim to improve the code structure and ensure that the correct parts of the code are compiled based on the defined flags.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
Implement AMQP message senders.
Refactored still more uAMQP only constructs out of Rust AMQP codebase (Link specifically).
Implemented basic AMQP message sender implementation (options don't currently work).
Added CBS deterministic close and message sender close methods.
This pull request to
sdk/core/azure-core-amqp
includes changes to improve the modularity and maintainability of the codebase. The most important changes involve reorganizing file inclusions, conditional compilation adjustments, and some code refactoring.File Reorganization:
sdk/core/azure-core-amqp/CMakeLists.txt
: Movedlink.cpp
andlink.hpp
to be included only whenUSE_UAMQP
is defined.Conditional Compilation Adjustments:
sdk/core/azure-core-amqp/inc/azure/core/amqp/internal/message_receiver.hpp
: WrappedGetLinkName
method with#if ENABLE_UAMQP
to conditionally compile it.sdk/core/azure-core-amqp/src/amqp/message_receiver.cpp
: WrappedGetLinkName
method with#if ENABLE_UAMQP
to conditionally compile it.sdk/core/azure-core-amqp/src/amqp/message_sender.cpp
: Added conditional compilation forOpen
,HalfOpen
, andGetLinkName
methods based onENABLE_UAMQP
andENABLE_RUST_AMQP
. [1] [2]sdk/core/azure-core-amqp/src/impl/rust_amqp/amqp/message_receiver.cpp
: RemovedENABLE_UAMQP
specific code and retained onlyENABLE_RUST_AMQP
implementation. [1] [2] [3]Code Refactoring:
sdk/core/azure-core-amqp/src/impl/rust_amqp/amqp/claim_based_security.cpp
: RefactoredClose
method to include proper context handling and error checking. RemovedOnError
method. [1] [2]Miscellaneous:
sdk/core/azure-core-amqp/inc/azure/core/amqp/internal/connection_string_credential.hpp
: Added missing copyright header.sdk/core/azure-core-amqp/inc/azure/core/amqp/internal/models/message_target.hpp
: Added a new friend classAmqpTargetFactory
toMessageTarget
class. [1] [2]These changes collectively aim to improve the code structure and ensure that the correct parts of the code are compiled based on the defined flags.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.