Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181 stars 126 forks source link

@override issues #6114

Closed gearama closed 3 weeks ago

gearama commented 1 month ago

given the following operation definition : /**

the generated code is

Azure::Response RestoreSecret(std::string const& apiVersion, SecretRestoreParameters const& parameters, Azure::Core::Context const& context = {}) ;

which is as expected

Adding the following defintion to the client.tsp : @override(KeyVault.restoreSecret,"cpp") /**

Azure::Response RestoreSecret(std::string const& apiVersion, SecretRestoreParameters const& parameters, Azure::Core::Context const& context = {}) ;

Azure::Response RestoreSecret(std::string const& apiVersion, SecretRestoreParameters const& parameters, Azure::Core::Context const& context = {}) ;

two methods with the same signature

i would expect one with the return type of BackupSecretResult not two with KeyVaultSecret or at least one with the right definition

at least that is my understanding based on https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/reference/decorators#@Azure.ClientGenerator.Core.override Decorators | TypeSpec Azure Azure.ClientGenerator.Core