search

Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181 stars 126 forks source link

Review and clean-up the headers publicly accessible in Azure::Data::Tables that don't need to be #6118

Closed ahsonkhan closed 1 month ago

ahsonkhan commented 1 month ago

We have certain headers in the inc folder of the package that don't need to be accessible to the end user, or used only in source and hence should move to the private directory of the src folder

For example: sdk/tables/azure-data-tables/inc/azure/data/tables/internal/cryptography/url_encode.hpp The UrlUtils class is only needed in source, and lives in _detail namespace. This can be moved out of the inc folder. https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-cpp+UrlUtils&type=code tables_sas_builder.cpp account_sas_builder.cpp

Also, since internal is meant for other SDKs within the repo to take a dependency on, it typically only makes sense for core. Unlike storage-common (outlier), no other service SDK or package will depend on types and methods within the internal folder for azure-data-tables.

Therefore, remove the internal folder and move the headers into the private folder within src. Only .cpp files use HmacSha256.

cc @RickWinter