This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181
stars
126
forks
source link
TableClientOptions contains a Nullable Audience extensible enum (TablesAudience) but it has no named enum values #6144
Is this options field needed or can it be removed? The doc comment seems to suggest it was copy/pasted from Blobs, but isn't applicable to Tables: https://github.com/Azure/azure-sdk-for-cpp/blob/d835e1a3b1970e53ceda94ef1c6d0596cd103d02/sdk/tables/azure-data-tables/inc/azure/data/tables/tables_clients.hpp#L119-L162
At a quick glance, none of the other language SDKs have it.
https://github.com/Azure/azure-sdk-for-net/blob/b1644182ddd5c19a004cb57551cc26835ebbc685/sdk/tables/Azure.Data.Tables/src/TableClientOptions.cs#L12
Outside of cosmos, the scope passed into the auth policy is hardcoded in other languages: https://github.com/Azure/azure-sdk-for-js/blob/d74b28cf794bc85ac95142867d4cc49f95982d3e/sdk/tables/data-tables/src/utils/constants.ts#L8 https://github.com/Azure/azure-sdk-for-go/blob/c4e56191456c45f561be3f20d1e92e9e2291ed1b/sdk/data/aztables/service_client.go#L35-L42
And we don't have test coverage for it:
cc @LarryOsterman, @RickWinter, @christothes