Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181 stars 126 forks source link

Removed builders from AMQP layer to conform to Rust guidelines; Fixed AMQP bug in message sender tests #6208

Closed LarryOsterman closed 1 week ago

LarryOsterman commented 2 weeks ago

Integrated Rust changes after API guidelines update which removed builders from ClientOptions related types.

Updated the Rust wrapper to reflect those changes. Also added a new API Wrapper for Rust APIs to handle APIs which return an i32 as an error.

Also fixed a bug in Rust MessageSender::detach - ignore SessionRemoteClosed errors on MessageSender::detach calls since RemoteClosed is an expected error in that case.

Also synchronized the root cargo.toml file with the root cargo.toml file from the rust repo.

Note for Reviewers: All the azure_core_amqp changes were already reviewed in an earlier PR to the Rust library, with the exception of fe2o3\sender.rs (which has the fix to detach I mentioned above)

CoPilot Summary

This pull request includes significant changes to the azure-core-amqp Rust and C++ codebase, focusing on simplifying the code by removing builder patterns and using a new InvokeAmqpApi function for error handling. Additionally, several dependencies in the Cargo.toml file have been updated.

Dependency Updates:

Code Simplification:

Removal of Builders:

Cleanup:

azure-sdk commented 2 weeks ago

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core-amqp-cpp

LarryOsterman commented 1 week ago

/azp run cpp - core - ci

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).