Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
181 stars 126 forks source link

Why does AddEntityOptions exists and why does it derive from UpsertEntityOptions (when UpdateEntityOptions and MergeEntityOptions don't) #6231

Open ahsonkhan opened 2 hours ago

ahsonkhan commented 2 hours ago

This options bag doesn't seem to be used to modify client behavior for TableClient::AddEntity: https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/tables/azure-data-tables/inc/azure/data/tables/models.hpp#L576-L585

https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/tables/azure-data-tables/src/table_clients.cpp#L445-L450

Following-up from https://github.com/Azure/azure-sdk-for-cpp/pull/6229#discussion_r1844470573

.NET doesn't expose this: https://github.com/Azure/azure-sdk-for-net/blob/4e1173308d32f0413788359a87376e673f2ab15b/sdk/tables/Azure.Data.Tables/src/TableClient.cs#L603

GoLang has it, but it contains MetadataFormat, rather than it being empty/inheriting from UpsertOptions: https://github.com/Azure/azure-sdk-for-go/blob/3ebd0d439f9d8aa06a0764a60892a8001b997a34/sdk/data/aztables/client.go#L247

cc @LarryOsterman (since this is regarding API review)

gearama commented 2 hours ago

works as exopected