Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.64k stars 844 forks source link

Support OMS auditing for SQL Server #14583

Closed nexxai closed 8 months ago

nexxai commented 3 years ago

Feature Request

Now that Azure SQL Server supports auditing using a Log Analytics Workspace as a target, it would be nice if it could actually be configured via the SDK.

Thoughts?

Screen Shot 2021-04-22 at 2 47 15 PM

The two fields that are pointed to with red arrows show fields that are currently accessible via the SDK, but the green arrow value is not, so while you can technically enable Log Analytics auditing, you can't choose the Workspace to send to.

nexxai commented 3 years ago

For reference, I believe the offending(?) block is here: https://github.com/Azure/azure-sdk-for-go/blob/master/services/preview/sql/mgmt/v4.0/sql/models.go#L5608

This code:

    IsAzureMonitorTargetEnabled *bool `json:"isAzureMonitorTargetEnabled,omitempty"`

allows you to enable Azure Monitor targeting, but there's no property to define the OMS Workspace

ArcturusZhang commented 3 years ago

Hi @nexxai thanks for this issue!

I just checked the corresponding swagger for sql composite-v4 - they do not have this functionality in the swagger. Therefore I have tagged this issue so that the service team could know of this and update their swagger, after that we could release a new SDK with the new functionalities.

ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureSQLGitHub.

Issue Details
### Feature Request Now that Azure SQL Server supports auditing using a Log Analytics Workspace as a target, it would be nice if it could actually be configured via the SDK. Thoughts? ![Screen Shot 2021-04-22 at 2 47 15 PM](https://user-images.githubusercontent.com/4316564/115786638-50b24800-a37e-11eb-954e-396b97ff48ae.png) The two fields that are pointed to with red arrows show fields that are currently accessible via the SDK, but the green arrow value is not, so while you can technically enable Log Analytics auditing, you can't choose the Workspace to send to.
Author: nexxai
Assignees: -
Labels: `SQL`, `Service Attention`, `customer-reported`, `needs-triage`, `question`
Milestone: -
github-actions[bot] commented 8 months ago

Hi @nexxai, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.