Support polling relative URLs

Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:

https://docs.microsoft.com/azure/developer/go/

MIT License

1.65k stars 846 forks source link

Support polling relative URLs #17221

Closed chlowell closed 8 months ago

chlowell commented 2 years ago

Today, pollers reject relative URLs: https://github.com/Azure/azure-sdk-for-go/blob/fc95da9cfa30aa95bb62d59950267634db929195/sdk/azcore/internal/pollers/util.go#L50-L53

I don't think anything other than autorest.testserver cases is blocked by this but grepping the Python repo I see that Azure Communication Services and Cognitive Services return relative URLs for polling, so it could be a future onboarding problem.

jhendrixMSFT commented 2 years ago

It could be that this requirement is specific to ARM, I'd have to go read their spec to confirm.

jhendrixMSFT commented 2 years ago

Confirmed, the ARM RPC spec requires the polling URIs to be absolute.

github-actions[bot] commented 8 months ago

Hi @chlowell, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.