search

Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.64k stars 841 forks source link

DetailedCostReportClient.BeginCreateOperation LRO returns wrong terminal success status #20342

Open jhendrixMSFT opened 1 year ago

jhendrixMSFT commented 1 year ago

It's returning Completed when per ARM RPC spec it should return Succeeded. This causes PollUntilDone() to essentially be in an infinite loop.

ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ccmixpdevs.

Issue Details
It's returning `Completed` when per ARM RPC spec it should return `Succeeded`. This causes `PollUntilDone()` to essentially be in an infinite loop.
Author: jhendrixMSFT
Assignees: -
Labels: `Service Attention`, `Service`, `Cost Management - Query`
Milestone: -
jhendrixMSFT commented 1 year ago

Since the service might not be able to change this due to back-compat concerns, we've added Completed to the list of terminal success status codes. Fix will be included in the next update of azcore post v1.4.0.

jhendrixMSFT commented 1 year ago

On further investigation, it appears the service is returning a provisioning state of Cancelled to indicate that the reservation has been cancelled, not that the LRO has been cancelled. Provisioning state is used to communicate the status of an LRO, not the state of the resource.

jhendrixMSFT commented 1 year ago

Ping @ccmixpdevs

flanakin commented 1 year ago

Can you remove the Cost Management - Query label? This is not using Query API. A different team owns this. If you have a label for Exports, use that.

ghost commented 1 year ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @TiagoCrewGitHubIssues.

Issue Details
It's returning `Completed` when per ARM RPC spec it should return `Succeeded`. This causes `PollUntilDone()` to essentially be in an infinite loop.
Author: jhendrixMSFT
Assignees: -
Labels: `Service Attention`, `Service`, `Cost Management - Query`, `Cost Management - UsageDetailsAndExport`
Milestone: -