armadvisor GetGenerateStatus hides relevant HTTP status information

joshk0 commented 9 months ago

Package: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/advisor/armadvisor SDK version: 1.2.0 Go version: go version go1.21.3 darwin/amd64

What happened? GetGenerateStatus is a call that tells you whether a recommendation generation operation has completed or not. The HTTP status code is Accepted if the operation is still ongoing and NoContent (204) if the operation has concluded. Otherwise a standard HTTP error. However, the response struct is empty, and will be the same whether 204 or Accepted was returned.
What did you expect or want to happen? The distinction should be made available via the repsonse struct or an additional return value.
How can we reproduce it? First, call GenerateRecommendations to get an operation ID (via *resp.Location), then pass it into GetGenerateStatus.
Anything we should know about your environment. Nothing special

joshk0 commented 9 months ago

See also #22306

github-actions[bot] commented 9 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mojayara @Prasanna-Padmanabhan.

Alancere commented 9 months ago

Azure / azure-sdk-for-go