search

Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.59k stars 821 forks source link

armeventhub namespaces client list pager responses have nil PrivateEndpointConnections #22736

Open rielida opened 4 months ago

rielida commented 4 months ago

Bug Report

When using the armeventhub list pager, PrivateEndpointConnection property is consistently returned nil across all namespaces.

Documentation indicates that the response should be generated based on the API version 2021-11-01. While the JSON object from the Azure portal, generated using this API version, does include the PrivateEndpointConnection property, this is not reflected in the SDK response.

Despite upgrading from version 1.0.0 to the latest version 1.2.0, the issue persists, with the PrivateEndpointConnection property still being returned as nil.

github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/eventhub/armeventhub

lirenhe commented 4 months ago

@Alancere, please help to check the root cause. Thanks

Alancere commented 4 months ago

Hi @rielida , could you provide your code for creating a private endpoint so that we can better repo it. Create a private endpoint if you don't already have one

github-actions[bot] commented 4 months ago

Hi @rielida. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

rielida commented 4 months ago

Hello @Alancere, I'm not responsible for creating the private endpoint, I only read Azure EventHub Namespaces. I use the armeventhub namespaces client list pager, and noticed that the PrivateEndpointConnection property is consistently empty.

Alancere commented 4 months ago

Hello @Alancere, I'm not responsible for creating the private endpoint, I only read Azure EventHub Namespaces. I use the armeventhub namespaces client list pager, and noticed that the PrivateEndpointConnection property is consistently empty.

Hi @rielida, if you need to use a private endpoint, create it first.

github-actions[bot] commented 4 months ago

Hi @rielida. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

rielida commented 4 months ago

Hi @Alancere, as I mentioned in my initial comment - The private endpoint has been set up and is visible in the Azure Portal; It's also included in the JSON object from there. However, when accessed via the SDK, it returns empty. Please review the bug description I provided. I believe you will be able to reproduce the issue.

Alancere commented 4 months ago

Hi @Alancere, as I mentioned in my initial comment - The private endpoint has been set up and is visible in the Azure Portal; It's also included in the JSON object from there. However, when accessed via the SDK, it returns empty. Please review the bug description I provided. I believe you will be able to reproduce the issue.

Sorry, that seems to be the case. Please try PrivateEndpointConnectionsClient.NewListPager

github-actions[bot] commented 4 months ago

Hi @rielida. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

github-actions[bot] commented 3 months ago

Hi @rielida, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

rielida commented 3 months ago

Hey @Alancere, this requires us to make a separate API call for each namespace, which is quite costly. Any chance you could populate the PrivateEndpointConnection field in the NamespacesClient.NewListPager response? It's already included in your response structure...

rielida commented 3 months ago

@lirenhe @Alancere, any update? Any chance you could populate the PrivateEndpointConnection field of the NamespacesClient.NewListPager response, instead of leaving it empty?

Alancere commented 3 months ago

I also debugged locally, and it seems that armeventhub.PrivateEndpointConnection is not returned. image

image

github-actions[bot] commented 3 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ArcturusZhang @lirenhe @tadelesh.

rielida commented 3 months ago

Hey @Alancere, thanks for debugging. Are you planning to populate the property?