Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.64k stars 842 forks source link

Remove azservicebus ApplicationInsights-Go requirement #23283

Closed chlowell closed 2 weeks ago

chlowell commented 3 months ago

After #23231, Component Governance still flags azservicebus for requiring yaml.v2@v2.2.1, apparently because that version still appears in go mod graph output. The lowest-effort solution that comes to my mind is moving the stress package into a separate module under testdata, like this.

richardpark-msft commented 3 months ago

Hm. I don't think moving it under testdata would be right because I want the project to be built along with the module it's testing.

I can think of a couple of other solutions:

lmolkova commented 3 months ago

Migrate over to the OpenTelemetry exporter

I'm very excited about it :) Also would be very surprised if exporter needed yaml.

richardpark-msft commented 3 months ago

Migrate over to the OpenTelemetry exporter

I'm very excited about it :) Also would be very surprised if exporter needed yaml.

Looking at the repo I think this might be a case of an indirect dependency of a dependency of a dependency, which might explain why we can't override it like we've tried (maybe). I'm investigating now to see if I can do a cheap fix, then a better one later.

richardpark-msft commented 2 weeks ago

This has been done. We can bring telemetry back using the opentelemetry exporter.