search

Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.64k stars 841 forks source link

Auto-generated PR from Swagger getting closed #23327

Closed bearzz23 closed 1 month ago

bearzz23 commented 2 months ago

Feature Request

Hello!

Our team has been making changes to Swagger API definitions (e.g. https://github.com/Azure/azure-rest-api-specs/pull/29148) which leads to PR to this Go SDK repository to be automatically created like this one: https://github.com/azure-sdk/azure-sdk-for-go/pull/10609, but all of them seem to be closed automatically after a while.

What is the correct process for getting these PRs merged and the SDK updated? Sorry if this has already been mentioned in a section in the Contribution guide (I can help updating the guide if needed. )

michaelschuett-tomtom commented 2 months ago

Could this be part of why I find a lot of things are missing in this SDK and most files that I find missing features are auto generated with no clear indicator of what needs to be changed? For example https://github.com/Azure/azure-sdk-for-go/pull/23323 that I opened yesterday.

lirenhe commented 2 months ago

For the PR about mgmt. plane in spec repo, we will create a SDK PR to verify whether we could still generate SDK from the modified spec and detect any breaking change in the SDK. Those PRs are for review only without the need to merge them. For SDK release, please create release request in release planner and Azure SDK team will handle it.

lirenhe commented 2 months ago

Could this be part of why I find a lot of things are missing in this SDK and most files that I find missing features are auto generated with no clear indicator of what needs to be changed? For example #23323 that I opened yesterday.

@michaelschuett-tomtom, I am not fully understand your ask, could you help to describe what you expected and what the actual behavior currently?

bearzz23 commented 2 months ago

Makes sense! Will use the Release Planner to create a release plan. Thanks for your help!

github-actions[bot] commented 1 month ago

Hi @bearzz23. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

github-actions[bot] commented 1 month ago

Hi @bearzz23, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.