search

Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.64k stars 844 forks source link

Incorrect code on Get Started Website #23488

Closed aryanmehrotra closed 3 weeks ago

aryanmehrotra commented 1 month ago

Hey, I am not sure if this is the right place to report but - code to start receiving from eventhub is wrong @ https://learn.microsoft.com/en-us/azure/event-hubs/event-hubs-go-get-started-send

Option param missing

if err := partitionClient.UpdateCheckpoint(context.TODO(), events[len(events)-1]); err != nil {

Should be 

if err := partitionClient.UpdateCheckpoint(context.TODO(), events[len(events)-1], nil); err != nil {
                return err
            }
github-actions[bot] commented 1 month ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

richardpark-msft commented 4 weeks ago

Created https://github.com/MicrosoftDocs/azure-docs/pull/124673/.

There were some other little housekeeping things to do as well so there are some small updates in there.

richardpark-msft commented 3 weeks ago

My PR's been merged and it looks like the sample is live. Thank you for pointing this out, apologies for taking so long to get to it.