Azure / azure-sdk-for-go

This repository is for active development of the Azure SDK for Go. For consumers of the SDK we recommend visiting our public developer docs at:
https://docs.microsoft.com/azure/developer/go/
MIT License
1.63k stars 835 forks source link

Missing Standard_DC2s and Standard_DC4s from models.go #7344

Closed annerajb closed 4 years ago

annerajb commented 4 years ago

Bug Report

ArcturusZhang commented 4 years ago

Hi @annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either.

annerajb commented 4 years ago

Can this be added to the latest API version?

On Tue, Feb 18, 2020, 2:17 AM Arcturus notifications@github.com wrote:

Hi @annerajb https://github.com/annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Azure/azure-sdk-for-go/issues/7344?email_source=notifications&email_token=AAGXQXV7EDO5RI52DAJ4ZVTRDODSNA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA3YJQ#issuecomment-587316262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTOZASUVCBYUHFIQRDRDODSNANCNFSM4KU3JYNQ .

ArcturusZhang commented 4 years ago

Can this be added to the latest API version? On Tue, Feb 18, 2020, 2:17 AM Arcturus @.***> wrote: Hi @annerajb https://github.com/annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344?email_source=notifications&email_token=AAGXQXV7EDO5RI52DAJ4ZVTRDODSNA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA3YJQ#issuecomment-587316262>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTOZASUVCBYUHFIQRDRDODSNANCNFSM4KU3JYNQ .

Well, I recommend you to open a new issue in the spec repo here with more context about this new value since the root cause of this issue is there. You can do it yourself, or if you can provide more information about this, I can do it for you. For instance, where can you find a full list of the vm sizes in the container services, and the list in swaggger is missing some items comparing to the full list. This kind of information can make more motivation for the service team to fix this up. Thanks!

annerajb commented 4 years ago

Please open since I don't have enough info to open this.

On Tue, Feb 18, 2020 at 10:00 PM Arcturus notifications@github.com wrote:

Can this be added to the latest API version? … <#m-2198976328237582433> On Tue, Feb 18, 2020, 2:17 AM Arcturus @.***> wrote: Hi @annerajb https://github.com/annerajb https://github.com/annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344 https://github.com/Azure/azure-sdk-for-go/issues/7344?email_source=notifications&email_token=AAGXQXV7EDO5RI52DAJ4ZVTRDODSNA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA3YJQ#issuecomment-587316262>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTOZASUVCBYUHFIQRDRDODSNANCNFSM4KU3JYNQ .

Well, I recommend you to open a new issue in the spec repo here https://github.com/Azure/azure-rest-api-specs/issues with more context about this new value since the root cause of this issue is there. You can do it yourself, or if you can provide more information about this, I can do it for you. For instance, where can you find a full list of the vm sizes in the container services, and the list in swaggger is missing some items comparing to the full list. This kind of information can make more motivation for the service team to fix this up. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Azure/azure-sdk-for-go/issues/7344?email_source=notifications&email_token=AAGXQXS3O34ELWSIBQE3XMTRDSODRA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGFIMY#issuecomment-588010547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXUCCLHI62BWIOJX76TRDSODRANCNFSM4KU3JYNQ .

ArcturusZhang commented 4 years ago

Please open since I don't have enough info to open this. On Tue, Feb 18, 2020 at 10:00 PM Arcturus @.> wrote: Can this be added to the latest API version? … <#m-2198976328237582433> On Tue, Feb 18, 2020, 2:17 AM Arcturus @.> wrote: Hi @annerajb https://github.com/annerajb https://github.com/annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344 <#7344>?email_source=notifications&email_token=AAGXQXV7EDO5RI52DAJ4ZVTRDODSNA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA3YJQ#issuecomment-587316262>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTOZASUVCBYUHFIQRDRDODSNANCNFSM4KU3JYNQ . Well, I recommend you to open a new issue in the spec repo here https://github.com/Azure/azure-rest-api-specs/issues with more context about this new value since the root cause of this issue is there. You can do it yourself, or if you can provide more information about this, I can do it for you. For instance, where can you find a full list of the vm sizes in the container services, and the list in swaggger is missing some items comparing to the full list. This kind of information can make more motivation for the service team to fix this up. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344?email_source=notifications&email_token=AAGXQXS3O34ELWSIBQE3XMTRDSODRA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGFIMY#issuecomment-588010547>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXUCCLHI62BWIOJX76TRDSODRANCNFSM4KU3JYNQ .

Well, at least I should know where I can find this full list. Otherwise I cannot help you

annerajb commented 4 years ago

Oh. Hmm I don't know where azure publishes the full list of vm sizes. I am not a go or powershell / CLI developer. I just noticed the missing confidential compute ones.

So you need to find the swagger where this list comes from to file the ticket?

On Thu, Feb 27, 2020, 12:10 AM Arcturus notifications@github.com wrote:

Please open since I don't have enough info to open this. … <#m4610496348533789370> On Tue, Feb 18, 2020 at 10:00 PM Arcturus @.> wrote: Can this be added to the latest API version? … <#m-2198976328237582433> On Tue, Feb 18, 2020, 2:17 AM Arcturus @.> wrote: Hi @annerajb https://github.com/annerajb https://github.com/annerajb https://github.com/annerajb thanks for this issue. For the api-version you are using (2018-03-31), all supported vm sizes are listed here: https://github.com/Azure/azure-rest-api-specs/blob/70593ff618236611e2c3265711f385e9c44cb4a0/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json#L787 I do not find any entry with value Standard_DC2s, you may need to recheck whether this vm size is already supported in this api-version. I have already checked the latest api-version 2020-02-01, there is no Standard_DC2s either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344 https://github.com/Azure/azure-sdk-for-go/issues/7344 <#7344 https://github.com/Azure/azure-sdk-for-go/issues/7344>?email_source=notifications&email_token=AAGXQXV7EDO5RI52DAJ4ZVTRDODSNA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA3YJQ#issuecomment-587316262>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTOZASUVCBYUHFIQRDRDODSNANCNFSM4KU3JYNQ . Well, I recommend you to open a new issue in the spec repo here https://github.com/Azure/azure-rest-api-specs/issues with more context about this new value since the root cause of this issue is there. You can do it yourself, or if you can provide more information about this, I can do it for you. For instance, where can you find a full list of the vm sizes in the container services, and the list in swaggger is missing some items comparing to the full list. This kind of information can make more motivation for the service team to fix this up. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7344 https://github.com/Azure/azure-sdk-for-go/issues/7344?email_source=notifications&email_token=AAGXQXS3O34ELWSIBQE3XMTRDSODRA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGFIMY#issuecomment-588010547>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXUCCLHI62BWIOJX76TRDSODRANCNFSM4KU3JYNQ .

Well, at least I should know where I can find this full list. Otherwise I cannot help you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Azure/azure-sdk-for-go/issues/7344?email_source=notifications&email_token=AAGXQXVCFROLQE5HEWVBUXTRE5DNXA5CNFSM4KU3JYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENC6WEQ#issuecomment-591784722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQXTACOUCD656URRKBWLRE5DNXANCNFSM4KU3JYNQ .

ArcturusZhang commented 4 years ago

Well, this is not language specific, and that is why i am thinking this issue is not an issue for go SDK based on the context of that go SDK is totally equivalent with swaggers. As for the vm sizes, I do find a similar VM size here. But this is for virtual machine in the compute service, not containerservice or AKS

no-response[bot] commented 4 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.