Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.32k stars 1.97k forks source link

This page is about deprecated feature #23269

Closed vgarmash closed 3 years ago

vgarmash commented 3 years ago

Please update the article with references to the current recommended approach as the use of filter is deprecated: https://github.com/Azure/azure-sdk-for-java/issues/17860


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

joshfree commented 3 years ago

@chenrujun could you please take a look?

chenrujun commented 3 years ago

Hi, @scbedd, could you please help to delete these contents, and not sync them again from this repo to doc repo again?

Related link: https://github.com/Azure/azure-docs-sdk-java/pull/2067#discussion_r671422787

scbedd commented 3 years ago

This is...odd. I definitely cleaned them out originally. I'll follow up. Thanks for the heads up @chenrujun

yiliuTo commented 3 years ago

Hey @scbedd , any updates? I also meet the simaliar issue: the deleted doc of Azure Event Hubs Spring Cloud Stream Binder client library for Java | Microsoft Docs can be searched

scbedd commented 3 years ago

@yiliuTo I got pre-occupied with other stuff. You should be clean when we release tomorrow. The exclusions have been added properly.

yiliuTo commented 3 years ago

@scbedd Thanks for helping on this! Besides, I found the exclusions don't cover the starter libraries, not sure if those should be added as well, or there has been other exclusion behavior already. And in case you need to add them in the exclusions, the starter librabries are:

azure-spring-boot-starter-active-directory azure-spring-boot-starter-active-directory-b2c azure-spring-boot-starter-cosmos azure-spring-boot-starter-keyvault-secrets azure-spring-boot-starter-servicebus-jms azure-spring-boot-starter-storage azure-spring-cloud-starter-eventhubs azure-spring-cloud-starter-eventhubs-kafka azure-spring-cloud-starter-servicebus azure-spring-cloud-starter-storage-queue

scbedd commented 3 years ago

Confirming those are gone here is the packages.json.

chenrujun commented 3 years ago

@scbedd . Thank you.

When will this page return 404? https://docs.microsoft.com/en-us/java/api/overview/azure/active-directory-spring-boot-starter-readme?view=azure-java-stable

scbedd commented 3 years ago

All the pages are gone now, but I don't think we cleaned out the readmes. I'll do another PR to clean those out and have this closed by the time you come for your next workday.

scbedd commented 3 years ago

Confirming these are gone. Closing.

chenrujun commented 3 years ago

Hi, @scbedd .

Thank you for your work.

But now I can still access this page: https://docs.microsoft.com/en-us/java/api/overview/azure/active-directory-spring-boot-starter-readme?view=azure-java-stable

chenrujun commented 3 years ago

Hi, @scbedd .

Now I can still access this page: https://docs.microsoft.com/en-us/java/api/overview/azure/active-directory-spring-boot-starter-readme?view=azure-java-stable

Could you please help to check?

scbedd commented 3 years ago

😡 😡 😡 😡 😡 😡 😡 😡 😡 😡

on it.

scbedd commented 3 years ago

@chenrujun this should be definitively closed now.

chenrujun commented 3 years ago

@scbedd . Thank you.