API visibility - all non-public APIs should be in “implementation” package

[saragluna]

In the review process of Sprig Cloud Azure 4.0, several classes are considered non-public APIs or chosen to expose later. We agree to move them to the "implementation" package.

• The *ClientBuilderFactory classes in the spring-cloud-azure-service package.
• The *ConfigurationProperties classes in the spring-cloud-azure-autoconfigure package (we will change the visibility of these classes).

[saragluna]

The *ClientBuilderFactory classes have been refactored in https://github.com/Azure/azure-sdk-for-java/pull/26409.

[saragluna]

For the *ConfigurationProperties classes, I've tried to make their visibility to package level, but it won't fit for most cases:

• We use the AzureComosProperties in spring-cloud-azure-actuator for the Cosmos health indicator.
• We use StorageBlobProperties in Event Hubs autoconfiguration for checkpoint store.
• We use the EventHubsProperties in the resource manager configuration.

So this solution won't work.

[lmolkova]

@saragluna thanks for the info! would it be possible to explore an implementation package option that allows keeping shared classes accessible for other packages?

[saragluna]

Hi @lmolkova, moving the ConfigurationProperties classes to the implementation package will introduce another problem, for our `Autoconfiguration` classes will reference these classes in their constructors.

[lmolkova]

Hi @lmolkova, moving the ConfigurationProperties classes to the implementation package will introduce another problem, for our `Autoconfiguration` classes will reference these classes in their constructors.

It can still be done with constructor injection (constructor would stay package-private) or am I missing something?

[saragluna]

I will try to move them.

[saragluna]

@lmolkova the pr has been merged.

[saragluna]

Closing this issue now for all related classes have been moved to impl packages.