search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.26k stars 1.94k forks source link

[FEATURE REQ] Customize Units used in MicroMeter Metrics for Cosmos DB SDK #38828

Open fernyettheplant opened 5 months ago

fernyettheplant commented 5 months ago

Is your feature request related to a problem? Please describe. Our team is currently using CosmosDB in our Java apps and we are integrating Dynatrace as our monitoring and alerting tool. However, after looking into an issue where we cannot see the CosmosDB metrics coming from the app and a warning related to the unit RU (Request Unit) coming from this line of code from Dynatrace we found out that the unit is hardcoded on these lines

Describe the solution you'd like A way to customize the Units that are going to be sent to Micrometer to be flexible with any vendor

Describe alternatives you've considered Make a PR to change only those three lines to just RU or Request_Unit but that may impact the metrics of folks that are already using the metrics emitted by the SDK

Additional context Nope

Information Checklist Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

Thank you in advance 🙂

joshfree commented 5 months ago

Thanks for filing this issue, @fernyettheplant. @kushagraThapar could you route this?

kushagraThapar commented 4 months ago

@fernyettheplant thanks for raising this issue, @FabianMeiswinkel can you please take a look at this and guide us in the right direction. How should we fix this issue?