search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.25k stars 1.93k forks source link

[BUG] sessionIdleTimeout property is missing in the Spring Cloud binder #39083

Open brunomace opened 4 months ago

brunomace commented 4 months ago

Describe the bug There is no way to set the sessionIdleTimeout property via Spring Cloud Stream.

Expected behavior It is not possible to set session idle timeout duration, so the application can't switch to another session if no message is received after some time.

Setup

Additional context It seems to be mismatch between Spring and Azure libraries. The sessionIdleTimeout property exists in the azure-messaging-servicebus library (defaut to null): https://github.com/Azure/azure-sdk-for-java/blob/azure-messaging-servicebus_7.15.0/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java#L1814 But this property is missing in the Spring properties: https://github.com/Azure/azure-sdk-for-java/blob/spring-cloud-azure-service_5.10.0/sdk/spring/spring-cloud-azure-service/src/main/java/com/azure/spring/cloud/service/implementation/servicebus/properties/ServiceBusProcessorClientProperties.java And so is not passed from Spring to Azure: https://github.com/Azure/azure-sdk-for-java/blob/spring-cloud-azure-service_5.10.0/sdk/spring/spring-cloud-azure-service/src/main/java/com/azure/spring/cloud/service/implementation/servicebus/factory/ServiceBusProcessorClientBuilderFactory.java#L86

joshfree commented 4 months ago

@yiliuTo could you please follow up?

Netyyyy commented 3 months ago

Hi @brunomace , Thank you for reporting this issue. We have received your submission and will take a look. We appreciate your input and will review this matter as soon as possible. Please feel free to provide any additional information or context that you think may be helpful. We'll keep you updated on the progress of our review.