search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.34k stars 1.98k forks source link

Update azure-analytics-defender-easm module, reflect latest spec #39862

Closed weidongxu-microsoft closed 2 months ago

weidongxu-microsoft commented 6 months ago

There is change in spec repo that changed the structure of the endpoint. https://github.com/Azure/azure-rest-api-specs/commit/690baaddc71ab873c83be33a74b4c0b9a044f594#diff-40d8b2cf9bb6658c4dbf874ca40a783caaff9fa377b605ccc5b8a9fe76f38005

Because of this, SDK cannot re-generate with latest spec. This changes breaks samples/tests.

Please update the azure-analytics-defender-easm module in Java to reflect latest spec.

  1. update tsp-location.yaml
  2. run tsp-client update
  3. one line modify on module-info.java, e.g. https://github.com/Azure/azure-sdk-for-java/pull/39861/commits/091efe35725e767aa8a60516b492a2ee77468467
  4. fix tests/samples
  5. record

A draft PR is prepared for you. Feel free to either use it or make a new PR. https://github.com/Azure/azure-sdk-for-java/pull/39861

weidongxu-microsoft commented 6 months ago

I see there is another PR pending in spec. https://github.com/Azure/azure-rest-api-specs/pull/28322

It would be fine if you do this on the next preview api-version.

weidongxu-microsoft commented 2 months ago

@thang-bit

I've regenerated the lib for you.

Please see if you can schedule a release.