search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.34k stars 1.98k forks source link

Spring Boot 3.3.0 support #40346

Closed dmarsh26 closed 4 months ago

dmarsh26 commented 5 months ago

Spring Boot 3.3.0 has now been released, can it be added to the compatibility list? https://github.com/spring-projects/spring-boot/releases

Compatible versions: https://github.com/Azure/azure-sdk-for-java/wiki/Spring-Versions-Mapping

github-actions[bot] commented 5 months ago

@chenrujun @moarychan @netyyyy @saragluna

github-actions[bot] commented 5 months ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

metron2 commented 5 months ago

This compatibility check is an anti-pattern. Can't it just be removed? If the library doesn't work, it won't work.

dmarsh26 commented 5 months ago

Yeah, I think documentation of tested combinations should be enough.

From: Derek Griffiths @.> Sent: Saturday, May 25, 2024 4:44:16 PM To: Azure/azure-sdk-for-java @.> Cc: dmarsh26 @.>; Author @.> Subject: Re: [Azure/azure-sdk-for-java] Spring Boot 3.3.0 support (Issue #40346)

This compatibility check is an anti-pattern. Can't it just be removed? If the library doesn't work, it won't work.

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-java/issues/40346#issuecomment-2131312723, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3JHP75HAMWKDM3ND3DOQ3ZECWVBAVCNFSM6AAAAABIHW7JPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGMYTENZSGM. You are receiving this because you authored the thread.Message ID: @.***>

saragluna commented 4 months ago

This compatibility check is an anti-pattern. Can't it just be removed? If the library doesn't work, it won't work.

Yes, I think we could remove this. The compatibility check is more like a protection for ourselves.

thibaut129 commented 4 months ago

Hi,

Any updates on this issue? Currently, we can’t migrate our project to Spring Boot 3.3.0 due to this functionality.

Thanks a lot.

LennartHaggkvist commented 4 months ago

Hi, We got problems since we are using Dependabot to manage our dependency updates - and dependabot updated to latest Spring Boot (3.3.0, and not 3.2.6) in our parent project and then we got the above error in our 25+ microservices...

mnhock commented 4 months ago

Hi!

We are currently unable to migrate our projects to Spring Boot 3.3.0 due to this functionality. Any updates on this?

Thank you very much!

philipschikora commented 4 months ago

Will this work with native compilation?

davidkarlsen commented 4 months ago

@LennartHaggkvist U need to control the dependency chain independently if you really do "micro-services" :) You're dependabot PRs might break, but that should be it. @mnhock the change on azure side will probably be nothing else than bumping the spring version, as confirmed in https://github.com/Azure/azure-sdk-for-java/issues/40346#issuecomment-2134723138 and seen in previous releases on this subject - this issue is really an invented issue, it either works or it doesn't: https://github.com/Azure/azure-sdk-for-java/issues/40346#issuecomment-2131312723 @philipschikora probably - if it does today - also a https://github.com/Azure/azure-sdk-for-java/issues/40346#issuecomment-2131312723

saragluna commented 4 months ago

We are working on this change and a new release will be out early next week if everything goes fine. And in the next version, we will disable the compatibility verifier by default.

Netyyyy commented 4 months ago

Disabled in https://github.com/Azure/azure-sdk-for-java/pull/40407

KrohnicDev commented 4 months ago

To anyone who is currently blocked by this: You can just set spring.cloud.azure.compatibility-verifier.enabled=false to disable that compatibility check.

mhalbritter commented 4 months ago

5.13.0 has been released with support for Spring Boot 3.3.x.

Netyyyy commented 4 months ago

close for released