search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.32k stars 1.97k forks source link

Remove azure-cosmos-spark_3_2-12 from parent pom identifiers #40813

Closed JimSuplizio closed 3 months ago

JimSuplizio commented 3 months ago

@alzimmermsft and I chatted and com.azure.cosmos.spark:azure-cosmos-spark_3_2-12 needs to be kept in the valid_parents, since it's being used as a parent to the other spark libraries and removing it from the parent_pom_identifiers is the right call. Things in parent_pom_identifiers won't get scanned for dependencies which is the problem that we're running into. Cosmos added com.azure:azure-cosmos-test as a dependency for com.azure.cosmos.spark:azure-cosmos-spark_3_2-12 and because this was in the parent_pom_identifiers, it wasn't getting scanned and added to the from source pom.

We believe this change to be safe and, for testing, I'm going to run the CI pipelines for

which should hopefully ferret out any issues that might exist.

JimSuplizio commented 3 months ago

I'm merging without waiting for requirements. Nothing runs automatically with these changes and I've linked the CI runs I ran against this PR, and their results, in the description. Also, @alzimmermsft approved the changes and he's the only other one that knows this file.