search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.25k stars 1.93k forks source link

Azure monitor exporter remove unused models #40911

Closed lmolkova closed 5 days ago

lmolkova commented 5 days ago

We're migrating libraries to azure-json (homegrown json library). Removing unused models would simplify it a bit.

The PR removes AvailabilityData, PageViewData, PageViewPerfData (and their builders) which are not expected (?) to be ever reported by Java application. Apparently EventData is not used as well.

These are also never mentioned in https://github.com/Azure/azure-sdk-for-java/blob/0f3357f229887fea4644305ef3a68080803fa91d/sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/models/MonitorDomain.java#L29C14-L29C28

And it's not clear if deserialization would even work.

Wonder if there are any hidden dangers of removing these

/cc @trask @heyams @alzimmermsft

azure-sdk commented 5 days ago

API change check

API changes are not detected in this pull request.

trask commented 5 days ago

we use these from the Java agent when bridging from the "classic SDK", e.g. https://github.com/microsoft/ApplicationInsights-Java/blob/d1f7caf742d4f191e3960b8f3b2efcbc197a310b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/BytecodeUtilImpl.java#L414-L415

lmolkova commented 5 days ago

thanks @trask, good to know