Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.

MIT License

2.25k stars 1.93k forks source link

Only wrap exceptions in CosmosException - 400 for custom serializers #40913

Closed FabianMeiswinkel closed 4 days ago

FabianMeiswinkel commented 5 days ago

Description

Previous change started wrapping all Exceptions in all CosmosItemSerializers in a CosmosExceptions. This was intended for custom serializers - but not for the "default" path - we should not change exception types there.

All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - spark

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - spark

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - tests

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - spark

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - tests

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - ci

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - tests

FabianMeiswinkel commented 5 days ago

/azp run java - cosmos - spark

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] commented 5 days ago

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel commented 4 days ago

/check-enforcer override

FabianMeiswinkel commented 4 days ago

All tests including spark and live tests passed. Could not merge because of permanent status "Checking for ability to merge automatically" - tried pushing a random change (and reverting it) - it restarted tests but did not allow the auto-merge :-(

So, going to skip live tests and spark now and will override check-enforcer this time because all tests passed with these changes.

FabianMeiswinkel commented 4 days ago

/check-enforcer override