java.lang.NullPointerException when application properties with null value are present

[mikemwalsh]

In a new edge case we are forwarding AMQP messages from another AMQP broker to event hub. The source allows application properties with a value of null. When this occurs, the code linked below throws a null pointer exception because there is no null checking in the sizeof call for the property values

https://github.com/Azure/azure-sdk-for-java/blob/f0bb03edd0c46d198093d73ea932bb9f6d05cc98/sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubMessageSerializer.java#L89

Reproduction:

• Create the application property map with a key value/pair containing a null value.

Suggested Fix:

• Check for null values before calling sizeof
• If null, I assume size of value should be 0?
• Size of key should still be included.
• Worth looking at line 80 as well for annotation as it seems it could have the same issue.

[github-actions[bot]]

@anuchandy @conniey @lmolkova

[github-actions[bot]]

Thank you for your feedback. Tagging and routing to the team member best able to assist.