search

Azure / azure-sdk-for-java

This repository is for active development of the Azure SDK for Java. For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/java/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-java.
MIT License
2.3k stars 1.96k forks source link

[QUERY] Oauth logging noise #41569

Closed anusudarsan closed 2 weeks ago

anusudarsan commented 3 weeks ago

Query/Question

This is a follow up request to https://github.com/Azure/azure-sdk-for-java/issues/39063 . We are seeing a lot of logging from the https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core/src/main/java/com/azure/core/implementation/AccessTokenCache.java#L231 AccessTokenCache refresh. Would it make sense to reduce this noise similar to the fix in https://github.com/Azure/azure-sdk-for-java/pull/39459 ?

2024-08-20T09:58:14.7529507Z 2024-08-20T03:58:14.738-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:14.8529761Z 2024-08-20T03:58:14.825-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:15.0533230Z 2024-08-20T03:58:14.980-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:15.1534094Z 2024-08-20T03:58:15.058-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:15.7543948Z 2024-08-20T03:58:15.653-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:15.8542164Z 2024-08-20T03:58:15.807-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}
2024-08-20T09:58:15.9543711Z 2024-08-20T03:58:15.880-0600   INFO    ForkJoinPool.commonPool-worker-1    com.azure.core.implementation.AccessTokenCache  {"az.sdk.message":"Acquired a new access token."}

Setup (please complete the following information if applicable):

This happens while authenticating with OAuth in the CI tests.

Information Checklist Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

joshfree commented 3 weeks ago

@billwert PTAL

billwert commented 2 weeks ago

Hello! Can you tell me a little about your tests? Are these many threads all getting their own credential?

We'll take a look at logging here. Thanks for letting us know.