joshfree
commented
1 week ago @trask @lmolkova could you please assist?
Open narendrasinghdanu opened 1 week ago
joshfree
commented
1 week ago @trask @lmolkova could you please assist?
trask
commented
1 week ago hi @narendrasinghdanu! the Azure SDK should work with both upstream OpenTelemetry Java agent, and also upstream OpenTelemetry Java SDK
I'm not quite following the issue you are seeing, can you provide more details, or even better a repro that we can run and use to investigate?
narendrasinghdanu
commented
3 days ago Hi @trask ,You are right, and that is my understanding as well. However, it is not working the same way. Below is my code where we expect it to create and push traces to App Insights whenever the application starts, and it is working perfectly. But in case there are any exceptions/issues occurring in any of the Azure library packages, for example, in the "Azure Key Vault Secrets client library" or Azure Blob Storage client library, while starting your Spring Boot project, it is looking for Java agents internally even though they are not defined there, which should not be the behaviour.
My OpenTelemetry bean:(this class should able to send traces to azure insight)
@Bean
public OpenTelemetry openTelemetry() {
String connectionString = secret.getConnetionStr()
AzureMonitorExporterBuilder azureMonitorExporterBuilder = new AzureMonitorExporterBuilder()
.connectionString(connectionString);
BatchSpanProcessor batchSpanProcessor = BatchSpanProcessor
.builder(azureMonitorExporterBuilder.buildTraceExporter())
.build();
Resource resource = Resource.create(Attributes.of(ResourceAttributes.SERVICE_NAME, this.serviceName));
SdkTracerProvider sdkTracerProvider = SdkTracerProvider.builder()
.addSpanProcessor(batchSpanProcessor)
.setResource(resource)
.build();
OpenTelemetrySdk openTelemetrySdk = OpenTelemetrySdk.builder()
.setTracerProvider(sdkTracerProvider)
.buildAndRegisterGlobal();
log.info("OpenTelemetry initialized");
return openTelemetrySdk;
}Springboot Logs where you can see that it is call the AgentContextStorage.getAgentContext
2024-10-16 15:32:06.021 DEBUG [main] [Logging_service - ClientLogger.performDeferredLogging:564] [, ] - Azure Identity => ERROR in EnvironmentCredential: Failed to create a ClientSecretCredential or ClientCertificateCredential. Missing required environment variable either AZURE_CLIENT_SECRET or AZURE_CLIENT_CERTIFICATE_PATH
2024-10-16 15:32:06.022 DEBUG [main] [Logging_service - ClientLogger.performDeferredLogging:564] [, ] - Azure Identity => ERROR in EnvironmentCredential: Failed to determine an authentication scheme based on the available environment variables. Please specify AZURE_TENANT_ID and AZURE_CLIENT_SECRET to authenticate through a ClientSecretCredential; AZURE_TENANT_ID and AZURE_CLIENT_CERTIFICATE_PATH to authenticate through a ClientCertificateCredential; or AZURE_USERNAME and AZURE_PASSWORD to authenticate through a UserPasswordCredential.
2024-10-16 15:32:06.088 DEBUG [main] [Logging_service - Loggers$Slf4JLogger.debug:254] [, ] - Using Slf4j logging framework
2024-10-16 15:32:06.140 DEBUG [main] [Logging_service - ClientLogger.performLogging:513] [, ] - Azure Identity => Found the following environment variables: AZURE_CLIENT_ID, AZURE_TENANT_ID
2024-10-16 15:32:06.142 DEBUG [main] [Logging_service - ClientLogger.performLogging:513] [, ] - Azure Identity => Found the following environment variables: AZURE_CLIENT_ID, AZURE_TENANT_ID
2024-10-16 15:32:06.176 DEBUG [main] [Logging_service - ClientLogger.performDeferredLogging:564] [, ] - Using com.azure.core.tracing.opentelemetry.OpenTelemetryTracerProvider as the default com.azure.core.util.tracing.TracerProvider.
2024-10-16 15:32:06.185 DEBUG [main] [Logging_service - ClientLogger.performLogging:513] [, ] - Failed to resolve AgentContextStorage.getAgentContext or one of its dependencies java.lang.ClassNotFoundException: io.opentelemetry.javaagent.instrumentation.opentelemetryapi.context.AgentContextStorage at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592) at org.springframework.boot.loader.net.protocol.jar.JarUrlClassLoader.loadClass(JarUrlClassLoader.java:107) at org.springframework.boot.loader.launch.LaunchedClassLoader.loadClass(LaunchedClassLoader.java:91) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) at java.base/java.lang.Class.forName0(Native Method) at java.base/java.lang.Class.forName(Class.java:413) at java.base/java.lang.Class.forName(Class.java:404) at com.azure.core.tracing.opentelemetry.OpenTelemetryTracer.
2024-10-16 15:32:06.213 INFO [main] [Logging_service - GlobalOpenTelemetry.maybeAutoConfigureAndSetGlobal:234] [, ] - AutoConfiguredOpenTelemetrySdk found on classpath but automatic configuration is disabled. To enable, run your JVM with -Dotel.java.global-autoconfigure.enabled=true
Note :Once the above step happens, we started getting an exception that the default OpenTelemetry is already created and cannot assign a new OpenTelemetry bean. Exception Details: 024-10-07 17:15:28.124 ERROR [main] [Logging_service - SpringApplication.reportFailure:859] [, ] - Application run failed org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'openTelemetry' defined in class path resource [com/sample/org/config/OpenTelemetryConfig.class]: Failed to instantiate [io.opentelemetry.api.OpenTelemetry]: Factory method 'openTelemetry' threw exception with message: GlobalOpenTelemetry.set has already been called. GlobalOpenTelemetry.set must be called only once before any calls to GlobalOpenTelemetry.get. If you are using the OpenTelemetrySdk, use OpenTelemetrySdkBuilder.buildAndRegisterGlobal instead. Previous invocation set to cause of this exception. at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:648) at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:485)
------ my observation that it is that---- When you add com.azure.azure-core-tracing-opentelemetry:1.0.0-beta.50 , it automatically looks for java agents incase of exception /or any issue.
narendrasinghdanu
commented
1 day ago @trask @lmolkova , anything else needed from my side
Type of issue
Other (describe below)
Description
Issue: At the time of springboot application start, whenever there is an exception in any Azure core package (for example,
com.azure.security.*),com.azure.core.util.tracing.DefaultTracerProviderlooks for the defaultDefaultTracerProvider, which eventually looks for the Java classio.opentelemetry.javaagent.instrumentation.opentelemetryapi.context.AgentContextStorage. My use case is to push the traces into azure app insight without using the applicationinsight java agent therefore i am creating my customise Opentelemetry and we don't want to use the applicationinsightjavagent jar fileSo When this entire episode happens , it eventually call the AutoConfiguredOpenTelemetrySdk and set the default telemetry and tracer objects and which does not have any use.
Library causing the issue:
fyi- My use case is to push the traces into azure app insight without using the application-insight java agent therefore i am creating my customise Opentelemetry.
Page URL
https://learn.microsoft.com/en-us/java/api/overview/azure/core-tracing-opentelemetry-readme?view=azure-java-preview
Content source URL
https://github.com/Azure/azure-docs-sdk-java/blob/master/docs-ref-services/preview/core-tracing-opentelemetry-readme.md
Document Version Independent Id
249ef132-a34b-8c4b-e6e5-ec5dffbe1a30
Article author
@azure-sdk
Metadata