search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.09k stars 1.2k forks source link

Release @azure/arm-storage package supporting the api version 2017-10-01 #10390

Closed bganapa closed 4 years ago

bganapa commented 4 years ago

Is your feature request related to a problem? Please describe. AzureStack Storage RP supports only the api version 2017-10-01. Some of our big customers are asking for vscode storage extension and function extensions support . These extensions are moving to use the nodejs sdk from azuer-sdk-for-js. The earliest @azure/arm-storage package version is 0.1.0 and it is using the api version 2018-07-01. So we are in desperate need of @azure/arm-storage sdk that supports 2017-10-01 api version

Describe the solution you'd like Release a new storage management SDK supporting the api version 2017-10-01, The package could be versioned as 0.0.5

Describe alternatives you've considered Side by side loading of existing azure-arm-storage with the newer SDK. We are running in to issues when we try to side load the older form of SDK with the newer one. This is likely not supported

qiaozha commented 4 years ago

@bganapa Are you sure simply release @azure/arm-storage can replace azure-arm-storage if it can support api-version 2017-10-01? I remember I had a issue of other RP they found the dependency of vscode extension is not the same as @azure/arm- package but the same as azure-arm- package.

bganapa commented 4 years ago

@qiaozha @ramya-rao-a Thanks for the response here. @EricJizbaMSFT recently moved to azure-sdk-for-js @azure/arm- package with this PR Having the @azure/arm- package supporting 2017-10-01 is very much needed for us to enable vscode-storage/functions for azurestack . Please also let us know how i could generate locally this package with autorest to unblock us. Appreciate your help here https://github.com/microsoft/vscode-azurestorage/pull/728 https://github.com/microsoft/vscode-azurefunctions/pull/2257

qiaozha commented 4 years ago
  1. Do you just need a private package? or you need both a locally package and a published version of 2017-10-01 ? If it's a published package of version 2017-10-01 you need, have you confirmed with storage team about this release? Do they also agree on this release?
  2. Why do you insist on the 2017-10-01 version? I really don't think npm can allow us to release a package with its current version number less than the current one.
bganapa commented 4 years ago
  1. @qiaozha I have not confirmed with the storage team. Could you please loop them in here? I believe releasing it as the version 0.0.5 should not do any harm. We need a local private package to unlock us and then a public package. Again appreciate your quick response here
  2. I will be really surprised if npm doesnt allow packages to be updated with a older ones (think of many hotfix scnearios)
qiaozha commented 4 years ago

close this issue as there's an email thread following on it.